New Crowdin updates#450
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughUpdated three locale JSON files ( Changes
Sequence Diagram(s)(Skipped — changes are localization strings only; no control-flow or feature behavior to diagram.) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 23.67% 23.67%
=======================================
Files 36 36
Lines 2230 2230
=======================================
Hits 528 528
Misses 1666 1666
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
frontend/src/lib/i18n/locales/zh-TW.json (2)
25-27: Use consistent formality in similar UI contexts.Line 25 (existing) uses the formal pronoun "您" for the insecure redirect warning, but the new untrusted redirect message on line 27 uses the informal "你". For consistency in tone and user experience, both should match.
Apply this diff to align the formality:
- "continueUntrustedRedirectSubtitle": "你嘗試重新導向的域名與設定不符(<code>{{cookieDomain}}</code>)。你確定要繼續嗎？", + "continueUntrustedRedirectSubtitle": "您嘗試重新導向的域名與設定不符(<code>{{cookieDomain}}</code>)。您確定要繼續嗎？",
55-55: Align code formatting with rest of file.The file consistently uses
<code>HTML tags for code/variable formatting (e.g., lines 27, 33, 34, 59), but line 55 uses backticks aroundUSERS. For consistency and proper rendering, use the<code>tag format.Apply this diff:
- "forgotPasswordMessage": "透過修改 `USERS` 環境變數，你可以重設你的密碼。", + "forgotPasswordMessage": "透過修改 <code>USERS</code> 環境變數，你可以重設你的密碼。",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src/lib/i18n/locales/zh-TW.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
frontend/src/lib/i18n/locales/zh-TW.json (1)
17-23: JSON structure and translations look solid.All translations are consistent with existing terminology (e.g., "重新導向" for redirect, "OAuth 供應商" for provider). Template variables (
{{variable}}) and HTML tags are preserved correctly. Once the pronoun and code-formatting issues above are addressed, this is ready to merge.Also applies to: 26-27, 56-61
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src/lib/i18n/locales/zh-TW.json(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
frontend/src/lib/i18n/locales/zh-TW.json (1)
2-2: JSON structure and translations look good.The JSON syntax is valid, placeholders (e.g.,
{{cookieDomain}},{{username}}) are correctly preserved, HTML code tags are consistently used in most entries, and the Traditional Chinese translations are coherent. Once the pronoun inconsistencies are resolved, this update is ready.Also applies to: 17-27, 56-61
| "continueUntrustedRedirectTitle": "不受信任的重新導向", | ||
| "continueUntrustedRedirectSubtitle": "你嘗試重新導向的域名與設定不符(<code>{{cookieDomain}}</code>)。你確定要繼續嗎？", |
There was a problem hiding this comment.
Pronoun formality inconsistency: use "您" instead of "你".
Line 27 uses the informal second-person pronoun "你", while the rest of the localization file consistently uses the formal "您". This creates an inconsistent tone in the UI.
- "continueUntrustedRedirectSubtitle": "你嘗試重新導向的域名與設定不符(<code>{{cookieDomain}}</code>)。你確定要繼續嗎？",
+ "continueUntrustedRedirectSubtitle": "您嘗試重新導向的域名與設定不符(<code>{{cookieDomain}}</code>)。您確定要繼續嗎？",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "continueUntrustedRedirectTitle": "不受信任的重新導向", | |
| "continueUntrustedRedirectSubtitle": "你嘗試重新導向的域名與設定不符(<code>{{cookieDomain}}</code>)。你確定要繼續嗎？", | |
| "continueUntrustedRedirectTitle": "不受信任的重新導向", | |
| "continueUntrustedRedirectSubtitle": "您嘗試重新導向的域名與設定不符(<code>{{cookieDomain}}</code>)。您確定要繼續嗎？", |
🤖 Prompt for AI Agents
In frontend/src/lib/i18n/locales/zh-TW.json around lines 26 to 27, the subtitle
string uses the informal pronoun "你" while the rest of the file uses the formal
"您"; update the subtitle to use "您" (e.g., replace "你嘗試重新導向的域名與設定不符..." with
"您嘗試重新導向的域名與設定不符...") so the tone is consistent across the localization.
| "domainWarningSubtitle": "This instance is configured to be accessed from <code>{{appUrl}}</code>, but <code>{{currentUrl}}</code> is being used. If you proceed, you may encounter issues with authentication.", | ||
| "ignoreTitle": "Ignore", | ||
| "goToCorrectDomainTitle": "Go to correct domain" | ||
| "forgotPasswordMessage": "透過修改 `USERS` 環境變數，你可以重設你的密碼。", |
There was a problem hiding this comment.
Pronoun formality inconsistency and code tag formatting: use "您" instead of "你", and use <code> tags instead of backticks.
Line 55 uses the informal pronoun "你" (inconsistent with the formal "您" used throughout the file) and backticks around `USERS` instead of <code> tags used elsewhere. For consistency and proper HTML rendering, align this with the rest of the file.
- "forgotPasswordMessage": "透過修改 `USERS` 環境變數，你可以重設你的密碼。",
+ "forgotPasswordMessage": "透過修改 <code>USERS</code> 環境變數，您可以重設您的密碼。",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "forgotPasswordMessage": "透過修改 `USERS` 環境變數，你可以重設你的密碼。", | |
| "forgotPasswordMessage": "透過修改 <code>USERS</code> 環境變數，您可以重設您的密碼。", |
🤖 Prompt for AI Agents
frontend/src/lib/i18n/locales/zh-TW.json around line 55: the string uses the
informal pronoun "你" and backticks around `USERS`, which is inconsistent with
the rest of the file; change "你" to the formal "您" and replace the
backticks-wrapped `USERS` with an HTML <code>USERS</code> tag so the message
matches the file’s formality and code formatting conventions.
1 participant
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.