Skip to content

New Crowdin updates#797

Merged
steveiliop56 merged 24 commits intomainfrom
l10n_main
Apr 15, 2026
Merged

New Crowdin updates#797
steveiliop56 merged 24 commits intomainfrom
l10n_main

Conversation

@steveiliop56
Copy link
Copy Markdown
Member

@steveiliop56 steveiliop56 commented Apr 15, 2026

Summary by CodeRabbit

  • Chores
    • Updated domain-warning messages across many locales to a clearer, generic incorrect‑domain warning (preserving authentication caveat)
    • Expanded Russian translations for authorization flows and domain/auth labels
    • Minor Korean localization tweak to username logout phrasing for grammatical correctness

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 15, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

📝 Walkthrough

Walkthrough

Updated i18n strings across many frontend locale JSON files: most replace domainWarningSubtitle text that referenced {{appUrl}}/{{currentUrl}} with a generic incorrect-domain warning; ru-RU.json and ko-KR.json include additional translation edits.

Changes

Cohort / File(s) Summary
Domain warning subtitle (many locales)
frontend/src/lib/i18n/locales/af-ZA.json, es-ES.json, no-NO.json, pl-PL.json, pt-BR.json, pt-PT.json, ro-RO.json, sr-SP.json, sv-SE.json, tr-TR.json, vi-VN.json, ca-ES.json, cs-CZ.json, da-DK.json, de-DE.json, fi-FI.json, he-IL.json, it-IT.json, ja-JP.json, nl-NL.json, zh-TW.json, ar-SA.json, cs-CZ.json
Replaced domainWarningSubtitle values: removed explicit {{appUrl}}/{{currentUrl}} references and changed wording to a generic "accessing from incorrect domain" warning while keeping the authentication caveat.
Russian locale — extended translations
frontend/src/lib/i18n/locales/ru-RU.json
Multiple Russian translation updates: domainWarningSubtitle and many authorization/OAuth-related strings (titles, subtitles, error messages, scope names/descriptions) converted to Russian; larger set of locale value edits (+22/-22 lines).
Korean small edit
frontend/src/lib/i18n/locales/ko-KR.json
Minor adjustment to logoutUsernameSubtitle Korean phrasing: removed auxiliary particle while retaining {{username}} interpolation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • New Crowdin updates #740: Modifies the same domain-warning i18n keys across multiple locale JSON files (subtitle and related labels).
  • feat: invalid domain warning #332: Introduced domain warning UI and associated domainWarning* i18n keys used across locales (directly related to these translations).
  • New Crowdin updates #676: Adds/adjusts domain warning keys (domainWarningCurrent/domainWarningExpected) and updates related locale entries overlapping with this PR.

Poem

🐰 Hopping through strings, I tidy each tongue,
Swapping long URLs for warnings more young,
One nibble on placeholders, one soft rewrite,
Now domains sound kinder as day turns to night,
A carrot of clarity — translations all sung! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and generic, using a non-descriptive term 'New Crowdin updates' that doesn't convey meaningful information about the changeset. Use a more specific title that describes the main change, such as 'Update localized domain warning messages across all languages' or 'Simplify domain warning translations by removing URL placeholders'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch l10n_main

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.06%. Comparing base (c1dd37e) to head (6ae20ee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage   20.06%   20.06%           
=======================================
  Files          50       50           
  Lines        3993     3993           
=======================================
  Hits          801      801           
  Misses       3119     3119           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@frontend/src/lib/i18n/locales/pt-PT.json`:
- Line 60: The pt-PT translation for key "domainWarningSubtitle" uses pt-BR
phrasing; update the value for "domainWarningSubtitle" to European Portuguese
(tu/teu) wording—e.g. replace "Acessa essa instância de um domínio incorreto. Se
você continuar, você pode encontrar problemas com a autenticação." with a pt-PT
phrase such as "Acessas esta instância a partir de um domínio incorreto. Se
continuares, podes ter problemas com a autenticação." to match the rest of the
locale file.

In `@frontend/src/lib/i18n/locales/ru-RU.json`:
- Line 60: Replace the English value of the domainWarningSubtitle key with a
Russian translation so the locale file displays Russian to users; update the
value for "domainWarningSubtitle" to something like: "Вы получаете доступ к
этому экземпляру с неправильного домена. Если вы продолжите, могут возникнуть
проблемы с аутентификацией." and verify the wording with a native speaker or
Crowdin before merging.

In `@frontend/src/lib/i18n/locales/sr-SP.json`:
- Line 60: The JSON key "domainWarningSubtitle" in the sr-SP locale is
inadvertently in English; replace its value with the Serbian translation so it
matches the rest of sr-SP — update the "domainWarningSubtitle" entry to a
Serbian sentence (e.g., "Pristupate ovoj instanci sa pogrešne domene. Ako
nastavite, možete naići na probleme sa autentifikacijom.") ensuring proper
escaping and valid JSON formatting.

In `@frontend/src/lib/i18n/locales/tr-TR.json`:
- Line 60: The string for the key "domainWarningSubtitle" in tr-TR.json is still
in English; replace its value with a proper Turkish translation (for example:
"Bu örneğe yanlış bir alan adı üzerinden erişiyorsunuz. Devam ederseniz kimlik
doğrulama ile ilgili sorunlarla karşılaşabilirsiniz.") so the tr-TR locale is
fully localized and avoids mixed-language UI.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2858de05-e7a9-4eab-865e-26eaeeb9798b

📥 Commits

Reviewing files that changed from the base of the PR and between c1dd37e and 8ff6d48.

📒 Files selected for processing (12)
  • frontend/src/lib/i18n/locales/af-ZA.json
  • frontend/src/lib/i18n/locales/es-ES.json
  • frontend/src/lib/i18n/locales/no-NO.json
  • frontend/src/lib/i18n/locales/pl-PL.json
  • frontend/src/lib/i18n/locales/pt-BR.json
  • frontend/src/lib/i18n/locales/pt-PT.json
  • frontend/src/lib/i18n/locales/ro-RO.json
  • frontend/src/lib/i18n/locales/ru-RU.json
  • frontend/src/lib/i18n/locales/sr-SP.json
  • frontend/src/lib/i18n/locales/sv-SE.json
  • frontend/src/lib/i18n/locales/tr-TR.json
  • frontend/src/lib/i18n/locales/vi-VN.json

Comment thread frontend/src/lib/i18n/locales/pt-PT.json
Comment thread frontend/src/lib/i18n/locales/ru-RU.json
Comment thread frontend/src/lib/i18n/locales/sr-SP.json
Comment thread frontend/src/lib/i18n/locales/tr-TR.json
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@frontend/src/lib/i18n/locales/fi-FI.json`:
- Line 60: Replace the English value for the JSON key "domainWarningSubtitle" in
the Finnish locale file by providing a proper Finnish translation (e.g., "Käytät
tätä instanssia väärästä verkkotunnuksesta. Jos jatkat, saatat kohdata
todennukseen liittyviä ongelmia."). Update the value in the fi-FI JSON entry for
"domainWarningSubtitle", keep JSON formatting and punctuation consistent with
other keys, and run the i18n/localization lint or build step to verify there are
no syntax or missing-key regressions.

In `@frontend/src/lib/i18n/locales/nl-NL.json`:
- Line 60: The translation key "domainWarningSubtitle" is using formal pronouns
("U"/"u") while the rest of the locale uses informal tone; update the value for
domainWarningSubtitle to use informal Dutch pronouns ("je"/"jouw") so the tone
matches the rest of nl-NL.json—for example convert "U benadert deze
instantie..." and "Als u doorgaat..." to informal equivalents.

In `@frontend/src/lib/i18n/locales/zh-TW.json`:
- Line 60: The value for the locale key "domainWarningSubtitle" is still in
English; update the zh-TW JSON entry for "domainWarningSubtitle" to a proper
Traditional Chinese translation (e.g., "您正在從不正確的網域存取此實例。繼續可能會導致驗證問題。") and
ensure the JSON string is escaped and valid within
frontend/src/lib/i18n/locales/zh-TW.json so the UI no longer shows
mixed-language content.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a823399c-e6c3-46f2-ae30-2b7227f3e6c4

📥 Commits

Reviewing files that changed from the base of the PR and between 8ff6d48 and 6ae20ee.

📒 Files selected for processing (12)
  • frontend/src/lib/i18n/locales/ar-SA.json
  • frontend/src/lib/i18n/locales/ca-ES.json
  • frontend/src/lib/i18n/locales/cs-CZ.json
  • frontend/src/lib/i18n/locales/da-DK.json
  • frontend/src/lib/i18n/locales/de-DE.json
  • frontend/src/lib/i18n/locales/fi-FI.json
  • frontend/src/lib/i18n/locales/he-IL.json
  • frontend/src/lib/i18n/locales/it-IT.json
  • frontend/src/lib/i18n/locales/ja-JP.json
  • frontend/src/lib/i18n/locales/ko-KR.json
  • frontend/src/lib/i18n/locales/nl-NL.json
  • frontend/src/lib/i18n/locales/zh-TW.json
✅ Files skipped from review due to trivial changes (9)
  • frontend/src/lib/i18n/locales/it-IT.json
  • frontend/src/lib/i18n/locales/ca-ES.json
  • frontend/src/lib/i18n/locales/he-IL.json
  • frontend/src/lib/i18n/locales/ko-KR.json
  • frontend/src/lib/i18n/locales/cs-CZ.json
  • frontend/src/lib/i18n/locales/ar-SA.json
  • frontend/src/lib/i18n/locales/ja-JP.json
  • frontend/src/lib/i18n/locales/da-DK.json
  • frontend/src/lib/i18n/locales/de-DE.json

"invalidInput": "Virheellinen syöte",
"domainWarningTitle": "Virheellinen verkkotunnus",
"domainWarningSubtitle": "Tämä instanssi on määritelty käyttämään osoitetta <code>{{appUrl}}</code>, mutta nykyinen osoite on <code>{{currentUrl}}</code>. Jos jatkat, saatat törmätä ongelmiin autentikoinnissa.",
"domainWarningSubtitle": "You are accessing this instance from an incorrect domain. If you proceed, you may encounter issues with authentication.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Localize domainWarningSubtitle for the Finnish locale

Line 60 is currently in English inside fi-FI.json, which causes a visible i18n regression for Finnish users.

💡 Suggested fix
-    "domainWarningSubtitle": "You are accessing this instance from an incorrect domain. If you proceed, you may encounter issues with authentication.",
+    "domainWarningSubtitle": "Käytät tätä instanssia väärästä verkkotunnuksesta. Jos jatkat, todennuksessa voi ilmetä ongelmia.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"domainWarningSubtitle": "You are accessing this instance from an incorrect domain. If you proceed, you may encounter issues with authentication.",
"domainWarningSubtitle": "Käytät tätä instanssia väärästä verkkotunnuksesta. Jos jatkat, todennuksessa voi ilmetä ongelmia.",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@frontend/src/lib/i18n/locales/fi-FI.json` at line 60, Replace the English
value for the JSON key "domainWarningSubtitle" in the Finnish locale file by
providing a proper Finnish translation (e.g., "Käytät tätä instanssia väärästä
verkkotunnuksesta. Jos jatkat, saatat kohdata todennukseen liittyviä
ongelmia."). Update the value in the fi-FI JSON entry for
"domainWarningSubtitle", keep JSON formatting and punctuation consistent with
other keys, and run the i18n/localization lint or build step to verify there are
no syntax or missing-key regressions.

"invalidInput": "Ongeldige invoer",
"domainWarningTitle": "Ongeldig domein",
"domainWarningSubtitle": "Deze instantie is geconfigureerd voor toegang tot <code>{{appUrl}}</code>, maar <code>{{currentUrl}}</code> wordt gebruikt. Als je doorgaat, kun je problemen ondervinden met authenticatie.",
"domainWarningSubtitle": "U benadert deze instantie vanuit een onjuist domein. Als u doorgaat, kunt u problemen ondervinden met authenticatie.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Keep Dutch pronoun style consistent with the rest of the locale.

Line 60 switches to formal U/u, while this file predominantly uses informal je/jouw. That tone mismatch is noticeable in UI copy.

Suggested text update
-    "domainWarningSubtitle": "U benadert deze instantie vanuit een onjuist domein. Als u doorgaat, kunt u problemen ondervinden met authenticatie.",
+    "domainWarningSubtitle": "Je benadert deze instantie vanaf een onjuist domein. Als je doorgaat, kun je problemen ondervinden met authenticatie.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"domainWarningSubtitle": "U benadert deze instantie vanuit een onjuist domein. Als u doorgaat, kunt u problemen ondervinden met authenticatie.",
"domainWarningSubtitle": "Je benadert deze instantie vanaf een onjuist domein. Als je doorgaat, kun je problemen ondervinden met authenticatie.",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@frontend/src/lib/i18n/locales/nl-NL.json` at line 60, The translation key
"domainWarningSubtitle" is using formal pronouns ("U"/"u") while the rest of the
locale uses informal tone; update the value for domainWarningSubtitle to use
informal Dutch pronouns ("je"/"jouw") so the tone matches the rest of
nl-NL.json—for example convert "U benadert deze instantie..." and "Als u
doorgaat..." to informal equivalents.

"invalidInput": "無效的輸入",
"domainWarningTitle": "無效的網域",
"domainWarningSubtitle": "此服務設定為透過 <code>{{appUrl}}</code> 存取,但目前使用的是 <code>{{currentUrl}}</code>。若繼續操作,可能會遇到驗證問題。",
"domainWarningSubtitle": "You are accessing this instance from an incorrect domain. If you proceed, you may encounter issues with authentication.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Localize domainWarningSubtitle for zh-TW instead of English.

Line 60 is currently English, which causes mixed-language UI for Traditional Chinese users.

🌐 Suggested fix
-    "domainWarningSubtitle": "You are accessing this instance from an incorrect domain. If you proceed, you may encounter issues with authentication.",
+    "domainWarningSubtitle": "您正從錯誤的網域存取此執行個體。若繼續,您可能會遇到身分驗證問題。",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@frontend/src/lib/i18n/locales/zh-TW.json` at line 60, The value for the
locale key "domainWarningSubtitle" is still in English; update the zh-TW JSON
entry for "domainWarningSubtitle" to a proper Traditional Chinese translation
(e.g., "您正在從不正確的網域存取此實例。繼續可能會導致驗證問題。") and ensure the JSON string is escaped and
valid within frontend/src/lib/i18n/locales/zh-TW.json so the UI no longer shows
mixed-language content.

@steveiliop56 steveiliop56 merged commit 36c7872 into main Apr 15, 2026
8 checks passed
@steveiliop56 steveiliop56 deleted the l10n_main branch April 15, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant