fix FRAMEWORK_SEARCH_PATHS when using carthage - #203
Merged
Conversation
Contributor
|
Also if you're installing the Intercom framework manually, then the original implementation was correct: |
|
🥇 Thanks for this, whilst we're waiting for this to be merged, you can add use this in your |
Contributor
Author
|
hello? @browniefed ? any feedback? can we merge this? |
Contributor
|
v11.2 is out |
Contributor
|
@browniefed is there a reason that the original |
Contributor
|
Uhm no I don't believe so, throw a PR up and add it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to this commit 8a77f78 the package is currently broken for users who are using carthage instead of cocoapods