Skip to content

Fix intercom version - #92

Closed
tlenclos wants to merge 1 commit into
tinycreative:masterfrom
tlenclos:fix-intercom-version
Closed

Fix intercom version#92
tlenclos wants to merge 1 commit into
tinycreative:masterfrom
tlenclos:fix-intercom-version

Conversation

@tlenclos

@tlenclos tlenclos commented May 5, 2017

Copy link
Copy Markdown

This fixes the problem with the userHash method #91

Also it can only works with build tools 25 in app/build.gradle.

android {
    compileSdkVersion 25
    buildToolsVersion "25.0.2"

I have to admit that I'm a bit lost about the impact of building with a newer version of the build tools since they are not officially supported by React Native.

@ryankask

ryankask commented May 5, 2017

Copy link
Copy Markdown

I think this change should be rolled back. According to the RN docs, Android build tools 23.0.1 is still required.

This issues happens for a lot of React Native packages. For example, the popular Code Push package made the same change but then rolled it back.

@browniefed

Copy link
Copy Markdown
Contributor

I'm going on vacation. If you can add in the rollback back to 23.0.1 by ~2pm PST I can get it merged and shipped.
Otherwise I'm going to be gone until June.

@ryankask

ryankask commented May 5, 2017

Copy link
Copy Markdown

At the moment I'm using a fork of the package off version 5.8.1.

I've fixed an inconsistency between iOS and Android registration and I've been thinking about a few other changes so probably best to wait until you return.

Have a great holiday.

@browniefed

Copy link
Copy Markdown
Contributor

Sounds good, feel free to continue any conversation here and can resolve it when I'm back.

I actually do not use this package and let the community maintain it and just handle the shipping of features. So apologies for shipping breaking changes, I did a major version bump for that reason.

However I may have misunderstood some of the changes and didn't do an appropriate minor/major bump.

@tlenclos tlenclos mentioned this pull request May 7, 2017
@ricardofbarros

Copy link
Copy Markdown

We should roll back to 23.0.1. react-native-fbsdkpackage had the same problem recently. @tlenclos can you resolve the conflicts so we can get this merged?

@agrass

agrass commented Aug 28, 2017

Copy link
Copy Markdown

Hi! It is possible to use the react-native project with compileSdkVersion 25 or 26?? Or could be a little risky?

@agrass

agrass commented Aug 28, 2017

Copy link
Copy Markdown

@ryankask you are using with v23.0.1? When I try to use that I get this build errors #107

@evanjmg

evanjmg commented Jan 28, 2018

Copy link
Copy Markdown

You can use a higher build version and still run it on the v23 device. It was able to get it running simply by only changing this. 26 was required with firebase. No need to change anything else, leave it all 23

   compileSdkVersion 26
   buildToolsVersion "26.0.1"

@evanjmg evanjmg mentioned this pull request Jan 28, 2018
@browniefed browniefed closed this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants