Fix intercom version - #92
Conversation
|
I think this change should be rolled back. According to the RN docs, Android build tools 23.0.1 is still required. This issues happens for a lot of React Native packages. For example, the popular Code Push package made the same change but then rolled it back. |
|
I'm going on vacation. If you can add in the rollback back to 23.0.1 by ~2pm PST I can get it merged and shipped. |
|
At the moment I'm using a fork of the package off version 5.8.1. I've fixed an inconsistency between iOS and Android registration and I've been thinking about a few other changes so probably best to wait until you return. Have a great holiday. |
|
Sounds good, feel free to continue any conversation here and can resolve it when I'm back. I actually do not use this package and let the community maintain it and just handle the shipping of features. So apologies for shipping breaking changes, I did a major version bump for that reason. However I may have misunderstood some of the changes and didn't do an appropriate minor/major bump. |
|
We should roll back to 23.0.1. |
|
Hi! It is possible to use the react-native project with compileSdkVersion 25 or 26?? Or could be a little risky? |
|
You can use a higher build version and still run it on the v23 device. It was able to get it running simply by only changing this. 26 was required with firebase. No need to change anything else, leave it all 23 |
This fixes the problem with the userHash method #91
Also it can only works with build tools 25 in
app/build.gradle.I have to admit that I'm a bit lost about the impact of building with a newer version of the build tools since they are not officially supported by React Native.