feat: add L2CAP support#2
Merged
Merged
Conversation
acouvreur
marked this pull request as draft
April 2, 2026 18:41
acouvreur
marked this pull request as ready for review
April 2, 2026 21:56
Member
That is the best testing we can do at this point, probably. Now squash/merging, thanks for working on this @acouvreur |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for L2CAP APIs from CoreBluetooth.
Those APIs were introduced in
macOS 10.13+so it is still within bounds of the supported APIs described in the README.Context: I'm implementing OTS which uses L2CAP to transfer objects.
I've added l2cap support here, and used it in a modified version of the bluetooth library and could successfully transfer data over an L2CAP channel.
I will create the pull request to the bluetooth repository once this is merged.
Important: I've used Claude through GitHub Copilot to help me create these changes. I've carefully reviewed and understood every piece of produced code. However, I'm not an Objective-C developer, so I don't know if it misses something. So far everything looks good and simple to me.