net: use the netItoa shim in tlssock.go - #84
Open
0pcom wants to merge 1 commit into
Open
Conversation
tlssock.go still imported internal/itoa unconditionally, which go1.26 removed (its Itoa moved to internal/strconv). The repo already has the version-gated netItoa shim (itoa_go126.go / itoa_pre126.go) for exactly this; tlssock.go was the one remaining direct import. Fixes tinygo-org#57.
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57.
tlssock.gostill importedinternal/itoaunconditionally. go1.26 removed that package (itsItoamoved tointernal/strconv), and the repo already carries the version-gatednetItoashim (itoa_go126.go/itoa_pre126.go) for exactly this case —tlssock.gowas the one remaining direct import, as the issue guessed ("this may just be a silly mistake").One line changed plus the import removal;
tinygo test netpasses against go1.27 with the dev compiler.