runtime: print error when panicking with error interface type - #300
Merged
Conversation
| print(msg) | ||
| case error: | ||
| print(msg.Error()) | ||
| default: |
Member
There was a problem hiding this comment.
Thought, do we want to add a case fmt.Stringer?
Member
Author
There was a problem hiding this comment.
Good idea, panic() in the Go runtime also seems to accept that: https://play.golang.org/p/UOeakJdGX6_3
Member
Author
|
I have added some more cases, so that booleans, integers, and Stringer gets printed as well. This increases code size in some cases but it's not by a large margin and it is very useful for debugging. Also, if code size is a concern, it can be disabled using #299. |
johanbrandhorst
approved these changes
Apr 24, 2019
Member
|
Excellent work here. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.