Skip to content

Docs/i18n batch fix link localization#2508

Merged
senamakel merged 3 commits into
tinyhumansai:mainfrom
JAYcodr:docs/i18n-batch-fix-link-localization
May 23, 2026
Merged

Docs/i18n batch fix link localization#2508
senamakel merged 3 commits into
tinyhumansai:mainfrom
JAYcodr:docs/i18n-batch-fix-link-localization

Conversation

@JAYcodr
Copy link
Copy Markdown
Contributor

@JAYcodr JAYcodr commented May 22, 2026

Summary

  • Fix 17 internal links across 8 translated .zh-CN.md files that were still pointing to English .md targets when the corresponding .zh-CN.md versions already exist
  • Fix 1 bare Markdown code block (MD040) in frontend.zh-CN.md

Problem

After batches A–C2 landed, many .zh-CN.md files still contained internal links pointing to English .md targets. Chinese readers clicking these links would land on English pages instead of the available Chinese translations.

Solution

Scanned all translated files for links whose .zh-CN.md target already exists on main. Updated the link target while preserving the display text.

Files changed

File Fixes
developing/README.zh-CN.md getting-started.md.zh-CN.md; subconscious.md.zh-CN.md
developing/architecture/frontend.zh-CN.md Bare code block ``````text
developing/e2e-testing.zh-CN.md agent-observability.md.zh-CN.md
features/integrations/triggers.zh-CN.md 7 links: README.md, subconscious.md, meeting-agents.md, model-routing/README.md, privacy-and-security.md, auto-fetch.md.zh-CN.md equivalents
features/mascot/README.zh-CN.md cef.md.zh-CN.md
features/mascot/meeting-agents.zh-CN.md cef.md.zh-CN.md
features/native-tools/browser-and-computer.zh-CN.md cef.md.zh-CN.md; integrations/README.md.zh-CN.md
features/obsidian-wiki/memory-tree.zh-CN.md local-ai.md.zh-CN.md

Skipped (target .zh-CN.md does not yet exist)

  • ../../docs/*, ../../AGENTS.md, ../../CLAUDE.md, ../../CONTRIBUTING.md
  • ../features/cloud-deploy.md (Batch D pending)

Submission Checklist

  • (N/A: docs-only change, no executable code modified) Tests added or updated
  • (N/A: only .md files changed, no testable source lines changed) Diff coverage ≥ 80%
  • (N/A: no feature IDs or testable behavior changed) Coverage matrix updated
  • (N/A: no matrix entries affected) All affected feature IDs from the matrix are listed
  • (N/A: documentation only, no network code) No new external network dependencies introduced
  • (N/A: no release-cut surfaces touched) Manual smoke checklist updated
  • (N/A: no pre-existing issue for this docs batch) Linked issue closed

Impact

  • Runtime/platform impact: None
  • Performance/security/migration/compatibility: None
  • User-visible effect: Chinese documentation readers now stay in Chinese pages when following internal links

Related

  • Follow-up PR(s)/TODOs: Re-run link audit after Batch D (cloud-deploy) and Batch E (legal + home) merge

AI Authored PR Metadata

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: docs/i18n-batch-fix-link-localization
  • Commit SHA: ed7b0e02, 1cad3129

Validation Run

  • (N/A: only Markdown docs changed) pnpm --filter openhuman-app format:check
  • (N/A: only Markdown docs changed) pnpm typecheck
  • (N/A: no testable behavior changed) Focused tests
  • (N/A: no Rust code changed) Rust fmt/check
  • (N/A: no Tauri code changed) Tauri fmt/check

Validation Blocked

  • command:
  • error:
  • impact:

Behavior Changes

  • Intended behavior change: None
  • User-visible effect: Internal doc links now route to Chinese translations where available

Parity Contract

  • Legacy behavior preserved: N/A
  • Guard/fallback/dispatch parity checks: N/A

Duplicate / Superseded PR Handling

  • Duplicate PR(s):
  • Canonical PR: This PR
  • Resolution:

Summary by CodeRabbit

  • Documentation
    • Localized internal documentation links to Chinese-language equivalents across multiple guides.
    • Improved formatting to ensure correct rendering of code examples and routing descriptions.
    • Clarified Meeting Agents implementation notes and updated related references for consistency.

Review Change Stack

agent:skill-master added 2 commits May 23, 2026 06:59
…files

Fixes 14 internal links that were still pointing to English .md targets
when the corresponding .zh-CN.md files already exist on main:
- e2e-testing → agent-observability.zh-CN.md
- README → subconscious.zh-CN.md, getting-started.zh-CN.md
- triggers → meeting-agents.zh-CN.md, subconscious.zh-CN.md,
  auto-fetch.zh-CN.md, README.zh-CN.md, privacy-and-security.zh-CN.md,
  model-routing/README.zh-CN.md
- mascot/meeting-agents → cef.zh-CN.md
- mascot/README → cef.zh-CN.md
- browser-and-computer → cef.zh-CN.md, integrations/README.zh-CN.md
- memory-tree → local-ai.zh-CN.md

Also fixes one missed bare text for proper GitBook rendering.

Skipped links where .zh-CN.md target does not yet exist:
- ../../docs/*, ../../AGENTS.md, ../../CLAUDE.md,
  ../../CONTRIBUTING.md, ../features/cloud-deploy.md (Batch D not yet merged)
@JAYcodr JAYcodr requested a review from a team May 22, 2026 23:13
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4a1dc24f-b826-4147-bf65-67aa1627a69e

📥 Commits

Reviewing files that changed from the base of the PR and between 1cad312 and f778266.

📒 Files selected for processing (2)
  • gitbooks/features/mascot/meeting-agents.zh-CN.md
  • gitbooks/features/native-tools/browser-and-computer.zh-CN.md
✅ Files skipped from review due to trivial changes (1)
  • gitbooks/features/mascot/meeting-agents.zh-CN.md

📝 Walkthrough

Walkthrough

This PR updates Chinese gitbook pages to use localized zh-CN internal links, adds a text code-fence start for routing docs, and revises the meeting-agents entry to describe Google Meet’s CDP-driven join automation.

Changes

Chinese Documentation Localization

Layer / File(s) Summary
Chinese documentation link harmonization
gitbooks/developing/README.zh-CN.md, gitbooks/developing/e2e-testing.zh-CN.md, gitbooks/features/integrations/triggers.zh-CN.md, gitbooks/features/mascot/README.zh-CN.md, gitbooks/features/native-tools/browser-and-computer.zh-CN.md, gitbooks/features/obsidian-wiki/memory-tree.zh-CN.md
Replaces multiple internal links to point at zh-CN equivalents (e.g., getting-started, subconscious, agent-observability, model-routing, privacy-and-security, CEF, integrations, local-ai) across several Chinese documentation pages.
Documentation formatting and meeting-agents implementation details
gitbooks/developing/architecture/frontend.zh-CN.md, gitbooks/features/mascot/meeting-agents.zh-CN.md
Adds a ```text code-fence start for routing example rendering and updates the embedded Google Meet webview description to document CDP-driven join automation and recipe identifiers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • senamakel
  • graycyrus

Poem

🐰 I hopped through docs with nimble feet,
Swapped links to zh-CN, tidy and neat.
Fixed a code-fence so routes display true,
And whispered how Meet joins via CDP too.
The rabbit nodded — “Docs now speak you.”

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Docs/i18n batch fix link localization' clearly and concisely summarizes the main change: updating Chinese documentation links to point to localized .zh-CN.md files instead of English versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the working A PR that is being worked on by the team. label May 22, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
gitbooks/features/native-tools/browser-and-computer.zh-CN.md (1)

33-33: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Inconsistent link localization.

Line 16 correctly updates the CEF link to cef.zh-CN.md, but this line in the "另见" section still points to the English cef.md. For consistency within this Chinese documentation file, this should also point to the localized version.

📝 Suggested fix
-* [Chromium Embedded Framework](../../developing/cef.md) —— 运行时浏览器层。
+* [Chromium Embedded Framework](../../developing/cef.zh-CN.md) —— 运行时浏览器层。
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@gitbooks/features/native-tools/browser-and-computer.zh-CN.md` at line 33, The
"另见" entry still links to the English CEF doc; update the link target for the
"Chromium Embedded Framework" list item (the string currently pointing to
../../developing/cef.md) to the localized ../../developing/cef.zh-CN.md so the
file consistently uses the Chinese localization (match the change made at the
earlier CEF link).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@gitbooks/features/mascot/meeting-agents.zh-CN.md`:
- Line 85: The doc line incorrectly claims Google Meet is "zero-injection JS";
update the sentence to say that only the six zero-injection providers (not
including google-meet) avoid any injected scripts, while Google Meet uses CDP to
install JS bridges/recipes — see GOOGLE_MEET_RECIPE_JS and
provider_recipe_js("google-meet") which cause recipe.js to be injected via CDP
calls (Page.addScriptToEvaluateOnNewDocument and Runtime.evaluate) — so clarify
that Meet join automation is CDP-driven and that CDP is used to install bridging
scripts rather than true zero-injection delivery.

---

Outside diff comments:
In `@gitbooks/features/native-tools/browser-and-computer.zh-CN.md`:
- Line 33: The "另见" entry still links to the English CEF doc; update the link
target for the "Chromium Embedded Framework" list item (the string currently
pointing to ../../developing/cef.md) to the localized
../../developing/cef.zh-CN.md so the file consistently uses the Chinese
localization (match the change made at the earlier CEF link).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cfc68c06-53ec-4f52-99a1-092ba6c828c9

📥 Commits

Reviewing files that changed from the base of the PR and between e7e660f and 1cad312.

📒 Files selected for processing (8)
  • gitbooks/developing/README.zh-CN.md
  • gitbooks/developing/architecture/frontend.zh-CN.md
  • gitbooks/developing/e2e-testing.zh-CN.md
  • gitbooks/features/integrations/triggers.zh-CN.md
  • gitbooks/features/mascot/README.zh-CN.md
  • gitbooks/features/mascot/meeting-agents.zh-CN.md
  • gitbooks/features/native-tools/browser-and-computer.zh-CN.md
  • gitbooks/features/obsidian-wiki/memory-tree.zh-CN.md

Comment thread gitbooks/features/mascot/meeting-agents.zh-CN.md Outdated
@senamakel senamakel merged commit 838309e into tinyhumansai:main May 23, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

working A PR that is being worked on by the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants