Skip to content

docs: remove stale PR markers from coverage matrix#3064

Merged
senamakel merged 3 commits into
tinyhumansai:mainfrom
alexzhu0:codex/OH-2611-coverage-matrix-pr-markers
Jun 2, 2026
Merged

docs: remove stale PR markers from coverage matrix#3064
senamakel merged 3 commits into
tinyhumansai:mainfrom
alexzhu0:codex/OH-2611-coverage-matrix-pr-markers

Conversation

@alexzhu0
Copy link
Copy Markdown
Contributor

@alexzhu0 alexzhu0 commented May 31, 2026

Summary

  • Removes stale (this PR) markers from long-lived coverage matrix entries.
  • Keeps the existing coverage evidence, statuses, and issue references intact.
  • Replaces the one contextual marker with stable wording: (status surface).

Problem

  • docs/TEST-COVERAGE-MATRIX.md is a durable project tracking artifact.
  • Several rows still describe merged coverage evidence as (this PR), which becomes ambiguous once the rows live on main.
  • That wording makes future audits harder because readers cannot tell which PR the note originally referenced.

Solution

  • Remove PR-local parentheticals from coverage evidence rows.
  • Preserve the actual test paths and notes rather than rewriting coverage claims.
  • Verify that no this PR references remain in the coverage matrix.

Submission Checklist

If a section does not apply to this change, mark the item as N/A with a one-line reason. Do not delete items.

  • N/A: Documentation-only wording cleanup; no behavior or test logic changed.
  • N/A: Diff coverage gate was not run because no executable code changed.
  • N/A: Coverage matrix was the file updated.
  • N/A: No affected feature IDs; coverage semantics are unchanged.
  • No new external network dependencies introduced (mock backend used per Testing Strategy)
  • N/A: Manual smoke checklist not affected; this does not touch release-cut surfaces.
  • N/A: No linked issue is closed by this documentation cleanup.

Impact

  • Runtime/platform impact: none.
  • Documentation impact: coverage matrix entries now read as durable merged-state records instead of PR-local notes.

Related

  • Closes: N/A
  • Follow-up PR(s)/TODOs: none

AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: codex/OH-2611-coverage-matrix-pr-markers
  • Commit SHA: c6c79e0

Validation Run

  • pnpm --filter openhuman-app format:check (blocked after app Prettier passed; see below)
  • pnpm typecheck
  • Focused tests: N/A, documentation-only change
  • Rust fmt/check (if changed): N/A, no Rust files changed
  • Tauri fmt/check (if changed): N/A, no Tauri files changed
  • rg "this PR" -n docs/TEST-COVERAGE-MATRIX.md returned no matches
  • rg "Hermes tracked as follow-up under #1440 \\(#1440\\)" docs/TEST-COVERAGE-MATRIX.md returned no matches
  • node scripts/codex-pr-preflight.mjs --lightweight
  • git diff --check

Validation Blocked

  • command: env COREPACK_HOME=/Users/alex/PR/.corepack PNPM_HOME=/Users/alex/PR/.pnpm-home pnpm --filter openhuman-app format:check
  • error: sh: cargo: command not found
  • impact: The app Prettier phase passed, but Rust formatting and the pre-push hook cannot complete in this local environment until Cargo is installed.

Behavior Changes

  • Intended behavior change: none.
  • User-visible effect: none.

Parity Contract

  • Legacy behavior preserved: coverage paths, statuses, and notes are unchanged except for stale PR-local wording.
  • Guard/fallback/dispatch parity checks: N/A, documentation-only change.

Duplicate / Superseded PR Handling

  • Duplicate PR(s): none found during triage
  • Canonical PR: this PR
  • Resolution (closed/superseded/updated): N/A

Summary by CodeRabbit

  • Documentation
    • Updated internal test coverage documentation to reflect current coverage status across multiple feature areas.

Constraint: The matrix is a durable repository artifact, so PR-local wording becomes stale after merge.

Rejected: Rewrite coverage rows more broadly | unnecessary for removing stale PR-local markers.

Confidence: high

Scope-risk: narrow

Directive: Avoid leaving temporary PR references in long-lived coverage documentation.

Tested: rg 'this PR' docs/TEST-COVERAGE-MATRIX.md returned no matches; node scripts/codex-pr-preflight.mjs --lightweight; pnpm typecheck; git diff --check

Not-tested: Full format:check/pre-push hook; cargo is not installed in this environment, though the app Prettier phase passed.
@alexzhu0 alexzhu0 requested a review from a team May 31, 2026 05:15
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 31, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ad676120-0715-4ee5-9c56-e1643608c2cb

📥 Commits

Reviewing files that changed from the base of the PR and between c6c79e0 and a42c7f4.

📒 Files selected for processing (1)
  • docs/TEST-COVERAGE-MATRIX.md

📝 Walkthrough

Walkthrough

This PR updates docs/TEST-COVERAGE-MATRIX.md to finalize and normalize referenced test paths and coverage-status notes across multiple feature and tooling areas (autocomplete, voice/persona, system tools, browser, memory, messaging integrations, intelligence/insights, rewards/progression, settings, and migration).

Changes

Test Coverage Matrix Documentation Sync

Layer / File(s) Summary
User-Facing Feature Coverage
docs/TEST-COVERAGE-MATRIX.md
Autocomplete inline suggestion/debounce handling, Voice Intelligence mascot voice selection and persona rows, File System & Shell/Git tool entries, and Browser Open/Browser Automation rows updated with finalized test-path annotations and coverage notes.
Memory, Operations & Messaging Coverage
docs/TEST-COVERAGE-MATRIX.md
Memory Operations "Store Memory" roundtrip, Unified Messaging Hub WhatsApp/Slack/Yuanbao connection rows, and WhatsApp Agent Retrieval ingestion entry updated with finalized test-path listings and regional/spec notes.
Intelligence Engine, Insights, Rewards & Settings Coverage
docs/TEST-COVERAGE-MATRIX.md
Actionable item extraction and analyze trigger, Insights Dashboard memory/source filtering/search & retrieval, Rewards & Progression role unlocking and message count tracking, Settings meet-handoff guard, and Migration from OpenClaw rows updated with finalized test-path references and prior-state notes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • tinyhumansai/openhuman#1821: Introduced Mascot Voice Selection test coverage that is now reflected in this matrix documentation update.

Suggested labels

working

Suggested reviewers

  • graycyrus

Poem

🐰 I hopped through rows and columns neat,
Tucked each test path in its seat,
Coverage notes polished, trimmed, and bright,
Matrix synced beneath moonlight —
A carrot for checks, and all is right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing stale PR markers from the test coverage matrix documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the working A PR that is being worked on by the team. label May 31, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/TEST-COVERAGE-MATRIX.md`:
- Line 505: The table row in TEST-COVERAGE-MATRIX.md contains a duplicated issue
reference "(`#1440`)"; edit the row string that currently reads "Hermes tracked as
follow-up under `#1440` (`#1440`)" (in the Migration from another assistant entry)
to remove the second "(`#1440`)" so only one reference remains, leaving the rest
of the cell text unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2ebe17a5-7fff-4286-b952-11696048ed16

📥 Commits

Reviewing files that changed from the base of the PR and between 850d275 and 3199b3b.

📒 Files selected for processing (1)
  • docs/TEST-COVERAGE-MATRIX.md

Comment thread docs/TEST-COVERAGE-MATRIX.md Outdated
Constraint: CodeRabbit identified a duplicated tinyhumansai#1440 reference in the coverage matrix row.

Rejected: Leave the duplicated parenthetical as harmless | documentation cleanup should not preserve obvious noise.

Confidence: high

Scope-risk: narrow

Directive: Keep coverage matrix notes concise and single-sourced.

Tested: rg duplicate tinyhumansai#1440 coverage-matrix note; git diff --check

Not-tested: Full repository format/check; documentation-only follow-up.
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 31, 2026
@alexzhu0
Copy link
Copy Markdown
Contributor Author

Thanks for the checks. I rechecked this PR on current state:

  • The only true blocker is Rust Core Coverage (cargo-llvm-cov) failing.
  • Other core checks in this PR pass; remaining failures are likely rerun / shared-suite related.
  • This is likely a shared upstream/core coverage issue across the fix(codex): compare strict preflight paths by realpath #3060-3073 batch, not a regression from this PR's diff.
  • PR Submission Checklist has historical failed/cancelled runs due to workflow re-triggers.

@sanil-23 sanil-23 assigned sanil-23 and unassigned sanil-23 May 31, 2026
Copy link
Copy Markdown
Contributor

@sanil-23 sanil-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexzhu0 the code looks good — all the stale (this PR) markers are gone, coverage evidence and statuses are intact, and the CodeRabbit duplicate #1440 reference was already addressed in this commit. Clean diff.

CI is failing on Rust Core Coverage (cargo-llvm-cov) right now, which looks unrelated to a docs-only change. Once that's green I'll come back and approve. Let me know if you need help tracking it down.

@senamakel senamakel merged commit c6f4c65 into tinyhumansai:main Jun 2, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

working A PR that is being worked on by the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants