docs: remove stale PR markers from coverage matrix#3064
Conversation
Constraint: The matrix is a durable repository artifact, so PR-local wording becomes stale after merge. Rejected: Rewrite coverage rows more broadly | unnecessary for removing stale PR-local markers. Confidence: high Scope-risk: narrow Directive: Avoid leaving temporary PR references in long-lived coverage documentation. Tested: rg 'this PR' docs/TEST-COVERAGE-MATRIX.md returned no matches; node scripts/codex-pr-preflight.mjs --lightweight; pnpm typecheck; git diff --check Not-tested: Full format:check/pre-push hook; cargo is not installed in this environment, though the app Prettier phase passed.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates docs/TEST-COVERAGE-MATRIX.md to finalize and normalize referenced test paths and coverage-status notes across multiple feature and tooling areas (autocomplete, voice/persona, system tools, browser, memory, messaging integrations, intelligence/insights, rewards/progression, settings, and migration). ChangesTest Coverage Matrix Documentation Sync
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/TEST-COVERAGE-MATRIX.md`:
- Line 505: The table row in TEST-COVERAGE-MATRIX.md contains a duplicated issue
reference "(`#1440`)"; edit the row string that currently reads "Hermes tracked as
follow-up under `#1440` (`#1440`)" (in the Migration from another assistant entry)
to remove the second "(`#1440`)" so only one reference remains, leaving the rest
of the cell text unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2ebe17a5-7fff-4286-b952-11696048ed16
📒 Files selected for processing (1)
docs/TEST-COVERAGE-MATRIX.md
Constraint: CodeRabbit identified a duplicated tinyhumansai#1440 reference in the coverage matrix row. Rejected: Leave the duplicated parenthetical as harmless | documentation cleanup should not preserve obvious noise. Confidence: high Scope-risk: narrow Directive: Keep coverage matrix notes concise and single-sourced. Tested: rg duplicate tinyhumansai#1440 coverage-matrix note; git diff --check Not-tested: Full repository format/check; documentation-only follow-up.
|
Thanks for the checks. I rechecked this PR on current state:
|
sanil-23
left a comment
There was a problem hiding this comment.
@alexzhu0 the code looks good — all the stale (this PR) markers are gone, coverage evidence and statuses are intact, and the CodeRabbit duplicate #1440 reference was already addressed in this commit. Clean diff.
CI is failing on Rust Core Coverage (cargo-llvm-cov) right now, which looks unrelated to a docs-only change. Once that's green I'll come back and approve. Let me know if you need help tracking it down.
Summary
(this PR)markers from long-lived coverage matrix entries.(status surface).Problem
docs/TEST-COVERAGE-MATRIX.mdis a durable project tracking artifact.(this PR), which becomes ambiguous once the rows live onmain.Solution
this PRreferences remain in the coverage matrix.Submission Checklist
Impact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
codex/OH-2611-coverage-matrix-pr-markersc6c79e0Validation Run
pnpm --filter openhuman-app format:check(blocked after app Prettier passed; see below)pnpm typecheckrg "this PR" -n docs/TEST-COVERAGE-MATRIX.mdreturned no matchesrg "Hermes tracked as follow-up under #1440 \\(#1440\\)" docs/TEST-COVERAGE-MATRIX.mdreturned no matchesnode scripts/codex-pr-preflight.mjs --lightweightgit diff --checkValidation Blocked
command:env COREPACK_HOME=/Users/alex/PR/.corepack PNPM_HOME=/Users/alex/PR/.pnpm-home pnpm --filter openhuman-app format:checkerror:sh: cargo: command not foundimpact:The app Prettier phase passed, but Rust formatting and the pre-push hook cannot complete in this local environment until Cargo is installed.Behavior Changes
Parity Contract
Duplicate / Superseded PR Handling
Summary by CodeRabbit