Skip to content

docs: remove stale coverage matrix PR-local markers#3220

Open
alexzhu0 wants to merge 1 commit into
tinyhumansai:mainfrom
alexzhu0:codex/OH-3039-coverage-matrix-stable-markers
Open

docs: remove stale coverage matrix PR-local markers#3220
alexzhu0 wants to merge 1 commit into
tinyhumansai:mainfrom
alexzhu0:codex/OH-3039-coverage-matrix-stable-markers

Conversation

@alexzhu0
Copy link
Copy Markdown
Contributor

@alexzhu0 alexzhu0 commented Jun 2, 2026

Summary

  • Removes stale (this PR) markers from durable coverage matrix rows.
  • Keeps stable PR references such as #3039 where those rows already had one.
  • Leaves coverage paths, statuses, and notes unchanged.

Problem

  • docs/TEST-COVERAGE-MATRIX.md is a long-lived audit artifact.
  • Several newly merged rows still used PR-local wording like (this PR).
  • Once the rows live on main, that wording is ambiguous for future coverage audits.

Solution

  • Replace (this PR, #3039) with stable (#3039) references.
  • Remove bare (this PR) parentheticals where no durable PR number was present.
  • Keep the actual evidence and status text intact.

Submission Checklist

If a section does not apply to this change, mark the item as N/A with a one-line reason. Do not delete items.

  • N/A: Documentation-only wording cleanup; no behavior or test logic changed.
  • N/A: Diff coverage gate was not run because no executable code changed.
  • N/A: Coverage matrix was the file updated; coverage semantics are unchanged.
  • N/A: No affected feature IDs; this only removes PR-local wording from existing rows.
  • No new external network dependencies introduced.
  • N/A: Manual smoke checklist not affected; this does not touch release-cut surfaces.
  • N/A: No linked issue is closed by this documentation cleanup.

Impact

  • Runtime/platform impact: none.
  • Documentation impact: coverage matrix rows now read as durable merged-state records.

Related


AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: codex/OH-3039-coverage-matrix-stable-markers
  • Commit SHA: b5f7559

Validation Run

  • pnpm --filter openhuman-app format:check (blocked after Prettier passed; see Validation Blocked)
  • pnpm typecheck: N/A, documentation-only change
  • Focused tests: N/A, documentation-only change
  • Rust fmt/check (if changed): N/A, no Rust files changed
  • Tauri fmt/check (if changed): N/A, no Tauri files changed
  • rg "this PR" docs/TEST-COVERAGE-MATRIX.md returned no matches
  • node scripts/codex-pr-preflight.mjs --lightweight
  • git diff --check

Validation Blocked

  • command: pnpm --filter openhuman-app format:check
  • error: sh: cargo: command not found
  • impact: Prettier passed, but the Rust format phase cannot run in this local environment until Cargo is installed.

Behavior Changes

  • Intended behavior change: none.
  • User-visible effect: none.

Parity Contract

  • Legacy behavior preserved: coverage paths, statuses, and notes are unchanged.
  • Guard/fallback/dispatch parity checks: N/A, documentation-only change.

Duplicate / Superseded PR Handling

  • Duplicate PR(s): none found in the current open PR list during preflight.
  • Canonical PR: this PR
  • Resolution (closed/superseded/updated): N/A

Summary by CodeRabbit

  • Documentation
    • Updated test coverage matrix to reflect the removal of Knowledge Vaults due to feature deprecation
    • Added coverage documentation for MCP registry features: installation workflows, environment configuration with credentials, and UI client setup
    • Added coverage documentation for Settings features: approval history tracking and action timeout configuration

Constraint: coverage matrix rows now live beyond their originating PR context.\nRejected: leaving PR-local markers in durable docs | future audits would not know which PR is meant.\nConfidence: high\nScope-risk: narrow\nDirective: keep coverage evidence tied to stable issue or PR numbers, not transient phrases like this PR.\nTested: rg "this PR" docs/TEST-COVERAGE-MATRIX.md; node scripts/codex-pr-preflight.mjs --lightweight; git diff --check; pnpm --filter openhuman-app format:check reached cargo blocker after Prettier passed.\nNot-tested: full Rust format because cargo is not installed locally.
@alexzhu0 alexzhu0 requested a review from a team June 2, 2026 15:02
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 65afb281-5d00-44a4-8a62-e69ad604d332

📥 Commits

Reviewing files that changed from the base of the PR and between 873a74e and b5f7559.

📒 Files selected for processing (1)
  • docs/TEST-COVERAGE-MATRIX.md

📝 Walkthrough

Walkthrough

This PR updates the test coverage matrix documentation to reflect completed test coverage for MCP registry features and Settings controls. Coverage rows are added for MCP install→connect→tool_call workflows, environment reconfiguration with registry credentials, the MCP UI surface, and Settings features including Approval History and Action Timeout.

Changes

Test Coverage Matrix Updates

Layer / File(s) Summary
MCP registry and Settings feature coverage documentation
docs/TEST-COVERAGE-MATRIX.md
Test coverage matrix entries added for MCP registry workflows (install→connect→tool_call, env reconfiguration + registry credentials, MCP UI + setup-agent client) in Analysis Engine section and Settings features (Approval History, Action Timeout) in Account & Security section, with corresponding test paths and ✅ statuses.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

working

Poem

🐰 A matrix grows with rows so neat,
MCP flows and Settings complete,
Coverage marked with checkmarks true,
Documentation shiny and new! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: removing stale 'PR-local' markers from the coverage matrix documentation to ensure durability after merge.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the working A PR that is being worked on by the team. label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

working A PR that is being worked on by the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant