[codex] Add tool schema cleaning helpers - #20
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83008a6fa7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return None; | ||
| }; | ||
|
|
||
| let variant_type = obj.get("type")?.as_str()?; |
There was a problem hiding this comment.
Infer literal enum types instead of abandoning const-only unions
When a schema generator emits a literal union as anyOf/oneOf variants containing only const values, this ? returns None, so clean_for_gemini leaves the union shape in place after merely converting each const to a single-value enum. Const-only literal unions are valid and common JSON Schema for string literals, so Gemini-normalized tool schemas can still contain unsimplified unions and be rejected or become less useful; infer the type from the literal value or flatten without requiring a redundant type.
Useful? React with 👍 / 👎.
Summary
Adds provider-oriented JSON Schema cleaning helpers to
harness::toolso tool schemas can be normalized for model tool-calling compatibility before provider dispatch.This ports the OpenHuman
SchemaCleanrbehavior into TinyAgents with crate-native errors and tests. The cleaner resolves local$refs, strips provider-unsupported keywords, flattens literal unions, removes nullable variants, convertsconsttoenum, and breaks circular local refs safely.Validation
cargo fmt --checktimeout 180s cargo clippy --all-targets -- -D warningstimeout 120s cargo test schema_Full CI is left to GitHub runners.