Skip to content

[codex] Add tool schema cleaning helpers - #20

Merged
senamakel merged 2 commits into
mainfrom
openhuman/schema-cleanr-port
Jul 5, 2026
Merged

[codex] Add tool schema cleaning helpers#20
senamakel merged 2 commits into
mainfrom
openhuman/schema-cleanr-port

Conversation

@senamakel

@senamakel senamakel commented Jul 5, 2026

Copy link
Copy Markdown
Member

Summary

Adds provider-oriented JSON Schema cleaning helpers to harness::tool so tool schemas can be normalized for model tool-calling compatibility before provider dispatch.

This ports the OpenHuman SchemaCleanr behavior into TinyAgents with crate-native errors and tests. The cleaner resolves local $refs, strips provider-unsupported keywords, flattens literal unions, removes nullable variants, converts const to enum, and breaks circular local refs safely.

Validation

  • cargo fmt --check
  • timeout 180s cargo clippy --all-targets -- -D warnings
  • timeout 120s cargo test schema_

Full CI is left to GitHub runners.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 28117d8f-d358-445c-b353-539833a1a1b1

📥 Commits

Reviewing files that changed from the base of the PR and between e72036d and 83008a6.

📒 Files selected for processing (3)
  • src/harness/tool/mod.rs
  • src/harness/tool/schema.rs
  • src/harness/tool/schema_test.rs

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel marked this pull request as ready for review July 5, 2026 03:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83008a6fa7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

return None;
};

let variant_type = obj.get("type")?.as_str()?;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Infer literal enum types instead of abandoning const-only unions

When a schema generator emits a literal union as anyOf/oneOf variants containing only const values, this ? returns None, so clean_for_gemini leaves the union shape in place after merely converting each const to a single-value enum. Const-only literal unions are valid and common JSON Schema for string literals, so Gemini-normalized tool schemas can still contain unsimplified unions and be rejected or become less useful; infer the type from the literal value or flatten without requiring a redundant type.

Useful? React with 👍 / 👎.

@senamakel
senamakel merged commit 3d307e5 into main Jul 5, 2026
3 checks passed
@senamakel
senamakel deleted the openhuman/schema-cleanr-port branch July 5, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant