[codex] Add feature-gated time tools - #22
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb219efbbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _ => return None, | ||
| }; | ||
|
|
||
| let magnitude = Duration::seconds(n.saturating_mul(seconds_per)); |
There was a problem hiding this comment.
Reject out-of-range relative durations before constructing them
When the model supplies a very large relative expression such as 9223372036854776s, this calls chrono::Duration::seconds with a value above chrono's supported bound; chrono documents that this constructor panics when seconds exceed i64::MAX / 1000 (docs). Because tool arguments are model/user controlled, that malformed input can unwind the harness instead of returning a ToolResult::error; use checked multiplication plus Duration::try_seconds and surface an ordinary parse error for out-of-range durations.
Useful? React with 👍 / 👎.
Summary
Adds a new optional
toolsfeature and the first generic builtin tool family underharness::tools:CurrentTimeToolResolveTimeTooltime_tools()register_time_tools()The implementation ports the generic behavior from OpenHuman's
current_timeandresolve_timetools onto TinyAgents'Tool<State>interface while keeping the newchrono/chrono-tzdependencies out of the default feature set.Validation
cargo fmt --checktimeout 240s cargo clippy --features tools --all-targets -- -D warningstimeout 180s cargo test --features tools time_Full CI is left to GitHub runners.