Skip to content

[codex] Add feature-gated time tools - #22

Merged
senamakel merged 1 commit into
mainfrom
openhuman/time-tools
Jul 5, 2026
Merged

[codex] Add feature-gated time tools#22
senamakel merged 1 commit into
mainfrom
openhuman/time-tools

Conversation

@senamakel

Copy link
Copy Markdown
Member

Summary

Adds a new optional tools feature and the first generic builtin tool family under harness::tools:

  • CurrentTimeTool
  • ResolveTimeTool
  • time_tools()
  • register_time_tools()

The implementation ports the generic behavior from OpenHuman's current_time and resolve_time tools onto TinyAgents' Tool<State> interface while keeping the new chrono / chrono-tz dependencies out of the default feature set.

Validation

  • cargo fmt --check
  • timeout 240s cargo clippy --features tools --all-targets -- -D warnings
  • timeout 180s cargo test --features tools time_

Full CI is left to GitHub runners.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 87983a91-425a-45c8-895e-4d2c295f51ac

📥 Commits

Reviewing files that changed from the base of the PR and between e72036d and cb219ef.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • Cargo.toml
  • src/harness/mod.rs
  • src/harness/tools/mod.rs
  • src/harness/tools/time.rs
  • src/harness/tools/time_test.rs

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel marked this pull request as ready for review July 5, 2026 03:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb219efbbd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/harness/tools/time.rs
_ => return None,
};

let magnitude = Duration::seconds(n.saturating_mul(seconds_per));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject out-of-range relative durations before constructing them

When the model supplies a very large relative expression such as 9223372036854776s, this calls chrono::Duration::seconds with a value above chrono's supported bound; chrono documents that this constructor panics when seconds exceed i64::MAX / 1000 (docs). Because tool arguments are model/user controlled, that malformed input can unwind the harness instead of returning a ToolResult::error; use checked multiplication plus Duration::try_seconds and surface an ordinary parse error for out-of-range durations.

Useful? React with 👍 / 👎.

@senamakel
senamakel merged commit 81e6101 into main Jul 5, 2026
3 checks passed
@senamakel
senamakel deleted the openhuman/time-tools branch July 5, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant