Skip to content

TINYMCE-14527: add unit test for sidebar width during animation - #11215

Merged
michalnieruchalski-tiugo merged 1 commit into
mainfrom
feature/TINYMCE-14527
Aug 3, 2026
Merged

TINYMCE-14527: add unit test for sidebar width during animation#11215
michalnieruchalski-tiugo merged 1 commit into
mainfrom
feature/TINYMCE-14527

Conversation

@michalnieruchalski-tiugo

@michalnieruchalski-tiugo michalnieruchalski-tiugo commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Related Ticket: TINYMCE-14527

Description of Changes:

  • I'm only adding missing unit test in this PR
  • Sidebar content has to receive its full configured with during open animation, otherwise it would inherit it's size from it's parent width even during animation. This means that the text inside the sidebar would wrap during animation etc. Sidebar content's parent has overflow: hidden, so even if the child is wider than a parent during animation it looks okay.
  • Added tests to verify that sidebar content maintains its full configured width during the open (grow) animation
  • Added a test case to verify that when the editing-area minimum-width clamp applies, the sidebar content receives the resolved (clamped) width during the open animation

Pre-checks:

- [ ] Changelog entry added

  • Tests have been added (if applicable)
  • Branch prefixed with feature/, hotfix/ or spike/

Review:

  • Milestone set
    - [] Docs ticket created (if applicable)

GitHub issues (if applicable):

Summary by CodeRabbit

  • Tests
    • Added coverage for sidebar sizing during the opening animation.
    • Verified content width remains consistent with the sidebar and available editing area constraints.
    • Confirmed the resize control remains narrower than the sidebar content while animating.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 70475329-2701-48f1-9ce0-ed8437a183c9

📥 Commits

Reviewing files that changed from the base of the PR and between c750de3 and b12ff39.

📒 Files selected for processing (1)
  • modules/tinymce/src/themes/silver/test/ts/browser/sidebar/SidebarResizeTest.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • modules/tinymce/src/themes/silver/test/ts/browser/sidebar/SidebarResizeTest.ts

Walkthrough

Adds a TinyMCE test for sidebar content width during the opening animation. The test covers configured-width and editing-area-clamped cases and confirms that the content remains wider than the animated slider.

Changes

Sidebar resize animation coverage

Layer / File(s) Summary
Measuring sidebar animation test
modules/tinymce/src/themes/silver/test/ts/browser/sidebar/SidebarResizeTest.ts
Registers a measuring resizable sidebar. It verifies content width during opening for configured-width and editing-area-clamped cases. It also verifies that the content remains wider than the animated slider.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the added unit test for sidebar width during the open animation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@michalnieruchalski-tiugo
michalnieruchalski-tiugo marked this pull request as ready for review July 29, 2026 08:25
@michalnieruchalski-tiugo
michalnieruchalski-tiugo requested a review from a team as a code owner July 29, 2026 08:25
@michalnieruchalski-tiugo michalnieruchalski-tiugo added this to the 8.9 milestone Jul 29, 2026
@michalnieruchalski-tiugo
michalnieruchalski-tiugo requested review from a team, lorenzo-pomili, spocke and zuzanna-antas and removed request for a team July 29, 2026 08:26
@michalnieruchalski-tiugo
michalnieruchalski-tiugo merged commit 622ddb9 into main Aug 3, 2026
6 checks passed
@michalnieruchalski-tiugo
michalnieruchalski-tiugo deleted the feature/TINYMCE-14527 branch August 3, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants