Merged
Conversation
Contributor
|
We need to check that '.' is not a valid character in all the places we use this to escape things. I feel it's probably OK, but would want to validate or test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To support postgres schemas the only thing we need is to update the escaping function.
Closes #242
How did you test this change?
I've tested it manually, but I haven't found a good way how to test this without doing unrelated changes, because the
/testfolder has it's owntsconfigand doesn't have access directly to the src files that are not exposed. Which seems to be by design. But all tests of databases run over all engines and this isn't supported by SQLite to add it to the rest of sql tests.