Fix checkpoints when mixed data changes cancel - #297
Open
dajiaohuang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #296.
Preserve pending keyed-value changes when tabular changes cancel, and vice versa. Each checkpoint listener now checks that the other delta map is empty before restoring the previous checkpoint ID.
Adds two regression cases covering both cancellation directions, checkpoint IDs, listener notifications, undo, and redo. No public API or dependency changes.
How did you test this change?
compileForTestbuild passes, including export parity.git diff --checkpasses.test/unit/core/otherrun: 754 pass, two middleware synchronization cases fail (expectedA, receiveda). Both failures were reproduced after removing the checkpoint guards, verifying the source matched the base, and rebuilding. The guards were then restored and the native build and checkpoint tests rerun successfully. These are existing failures in this environment; their underlying cause is not diagnosed here.Environment: Windows, Node.js v24.14.1.