Skip to content

build(deps): pin tinyrack_ui to the unified border release - #90

Merged
winetree94 merged 1 commit into
mainfrom
settings-border-repin
Aug 7, 2026
Merged

build(deps): pin tinyrack_ui to the unified border release#90
winetree94 merged 1 commit into
mainfrom
settings-border-repin

Conversation

@winetree94

Copy link
Copy Markdown
Contributor

Why

The settings work left one thing unresolved: a card closed at #d4d4d4 while the field inside it closed at #737373, so a single screen showed two border weights with nothing to explain the difference.

Auditing where each came from turned up the cause upstream. border and controlBorder were different greys, while controlBorder and borderStrong were the same grey — two names for one value, which let components drift onto the wrong token invisibly. tinyrack-net/design#444 fixes both: border rises to meet controlBorder, and the resting borders that had reached for borderStrong move onto controlBorder.

What changes here

The pin only. A surface and the control sitting on it now share an edge — #737373 in light, #a3a3a3 in dark, one value per theme. Measured across the regenerated goldens, every structural line in a settings screen is now that single value; before, light mixed 212 (cards) with 115 (fields).

The pin also picks up #443, which had quieted popup layer borders. Those are louder again, for the reason below.

The trade-off

The resting border is louder than it was, not quieter — the opposite of where this started. The neutral ramp has no step between #a3a3a3 (2.31:1) and #737373 (4.35:1), and the design system holds controlBorder to 3:1 non-text contrast with a test. A quieter unified edge would have meant dropping control boundaries to roughly 1.5:1 and deleting that contract, so unification had to move upward.

Worth a look before this lands: if the heavier card outline reads as too much, the alternatives are to give up unification for surfaces, or to add a neutral.450 step upstream so the unified value can sit nearer #8e8e8e while still clearing 3:1.

Verification

  • dart run melos verify — 12/12.
  • 459 widget and unit tests.
  • 71 goldens regenerated; General, Daemons, Skill, and Workspaces reviewed in light and dark, and the single border value confirmed by sampling the rendered pixels rather than by eye.

@winetree94
winetree94 enabled auto-merge August 6, 2026 23:55
@winetree94
winetree94 added this pull request to the merge queue Aug 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Aug 7, 2026
A card closed at #d4d4d4 while the field inside it closed at #737373, so one
settings screen showed two border weights with nothing to explain the
difference. tinyrack-net/design#444 raises border to meet controlBorder, so a
surface and the control sitting on it now share an edge: #737373 in light,

The resting border is louder than it was rather than quieter. The neutral ramp
has no step between #a3a3a3 and #737373, and the design system holds
controlBorder to 3:1 non-text contrast, so a quieter unified edge would have
meant dropping control boundaries below that bar.

The pin also picks up #443, which had quieted popup layer borders; those are
louder again for the same reason.
@winetree94
winetree94 force-pushed the settings-border-repin branch from 4aa7201 to cb3243a Compare August 7, 2026 00:18
@winetree94
winetree94 enabled auto-merge August 7, 2026 00:18
@winetree94
winetree94 added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit 145721a Aug 7, 2026
34 checks passed
@winetree94
winetree94 deleted the settings-border-repin branch August 7, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant