build(deps): pin tinyrack_ui to the unified border release - #90
Merged
Conversation
winetree94
enabled auto-merge
August 6, 2026 23:55
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Aug 7, 2026
A card closed at #d4d4d4 while the field inside it closed at #737373, so one settings screen showed two border weights with nothing to explain the difference. tinyrack-net/design#444 raises border to meet controlBorder, so a surface and the control sitting on it now share an edge: #737373 in light, The resting border is louder than it was rather than quieter. The neutral ramp has no step between #a3a3a3 and #737373, and the design system holds controlBorder to 3:1 non-text contrast, so a quieter unified edge would have meant dropping control boundaries below that bar. The pin also picks up #443, which had quieted popup layer borders; those are louder again for the same reason.
winetree94
force-pushed
the
settings-border-repin
branch
from
August 7, 2026 00:18
4aa7201 to
cb3243a
Compare
winetree94
enabled auto-merge
August 7, 2026 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The settings work left one thing unresolved: a card closed at
#d4d4d4while the field inside it closed at#737373, so a single screen showed two border weights with nothing to explain the difference.Auditing where each came from turned up the cause upstream.
borderandcontrolBorderwere different greys, whilecontrolBorderandborderStrongwere the same grey — two names for one value, which let components drift onto the wrong token invisibly. tinyrack-net/design#444 fixes both:borderrises to meetcontrolBorder, and the resting borders that had reached forborderStrongmove ontocontrolBorder.What changes here
The pin only. A surface and the control sitting on it now share an edge —
#737373in light,#a3a3a3in dark, one value per theme. Measured across the regenerated goldens, every structural line in a settings screen is now that single value; before, light mixed212(cards) with115(fields).The pin also picks up #443, which had quieted popup layer borders. Those are louder again, for the reason below.
The trade-off
The resting border is louder than it was, not quieter — the opposite of where this started. The neutral ramp has no step between
#a3a3a3(2.31:1) and#737373(4.35:1), and the design system holdscontrolBorderto 3:1 non-text contrast with a test. A quieter unified edge would have meant dropping control boundaries to roughly 1.5:1 and deleting that contract, so unification had to move upward.Worth a look before this lands: if the heavier card outline reads as too much, the alternatives are to give up unification for surfaces, or to add a
neutral.450step upstream so the unified value can sit nearer#8e8e8ewhile still clearing 3:1.Verification
dart run melos verify— 12/12.