Release v2.6.0 - #13
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthrough
ChangesStatistics Integration
Sequence Diagram(s)sequenceDiagram
participant Coordinator
participant HonClient
participant Appliance
participant HonBaseEntity
Coordinator->>HonClient: _update_appliance_sync(appliance)
HonClient->>Appliance: update()
Appliance-->>HonClient: attributes (non-empty)
HonClient->>Appliance: load_statistics()
Appliance-->>HonClient: statistics populated
HonClient-->>Coordinator: snapshot includes statistics field
Coordinator->>HonBaseEntity: state update triggered
HonBaseEntity->>HonBaseEntity: _get_attr(key)
HonBaseEntity->>HonBaseEntity: check _statistics[key]
HonBaseEntity-->>HonBaseEntity: return normalized value from statistics
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
tis24dev
added a commit
that referenced
this pull request
Jun 23, 2026
#3: the watchdog rebuild (_start + _subscribe_appliances) sat outside try/except in 'while True', so a transient error (load_aws_token 5xx, subscribe timeout) ended the task and left realtime dead until a reload. Wrap the loop body: re-raise asyncio.CancelledError FIRST (stop() cancels+awaits the task, so swallowing it would deadlock shutdown), and on any other error log a WARNING (exc_info) and keep looping with an additive backoff (capped at 60s, reset on recovery) so a persistent 5xx is not hammered every tick. #13: _subscribe used a blocking awscrt future .result(_SUBSCRIBE_TIMEOUT), freezing the hon_loop up to 10s per topic. Make _subscribe/_subscribe_appliances async and await asyncio.wait_for(asyncio.wrap_future(future), _SUBSCRIBE_TIMEOUT) instead, yielding the loop while keeping the order and the timeout bound. Also use the null-tolerant _subscribed_topics() helper. Tests: watchdog survives a raising _start, propagates CancelledError, backoff grows/resets/caps; subscribe preserves order, yields the loop, honours the timeout.
tis24dev
added a commit
that referenced
this pull request
Jun 23, 2026
#3: the watchdog rebuild (_start + _subscribe_appliances) sat outside try/except in 'while True', so a transient error (load_aws_token 5xx, subscribe timeout) ended the task and left realtime dead until a reload. Wrap the loop body: re-raise asyncio.CancelledError FIRST (stop() cancels+awaits the task, so swallowing it would deadlock shutdown), and on any other error log a WARNING (exc_info) and keep looping with an additive backoff (capped at 60s, reset on recovery) so a persistent 5xx is not hammered every tick. #13: _subscribe used a blocking awscrt future .result(_SUBSCRIBE_TIMEOUT), freezing the hon_loop up to 10s per topic. Make _subscribe/_subscribe_appliances async and await asyncio.wait_for(asyncio.wrap_future(future), _SUBSCRIBE_TIMEOUT) instead, yielding the loop while keeping the order and the timeout bound. Also use the null-tolerant _subscribed_topics() helper. Tests: watchdog survives a raising _start, propagates CancelledError, backoff grows/resets/caps; subscribe preserves order, yields the loop, honours the timeout.
tis24dev
added a commit
that referenced
this pull request
Jun 23, 2026
#3: the watchdog rebuild (_start + _subscribe_appliances) sat outside try/except in 'while True', so a transient error (load_aws_token 5xx, subscribe timeout) ended the task and left realtime dead until a reload. Wrap the loop body: re-raise asyncio.CancelledError FIRST (stop() cancels+awaits the task, so swallowing it would deadlock shutdown), and on any other error log a WARNING (exc_info) and keep looping with an additive backoff (capped at 60s, reset on recovery) so a persistent 5xx is not hammered every tick. #13: _subscribe used a blocking awscrt future .result(_SUBSCRIBE_TIMEOUT), freezing the hon_loop up to 10s per topic. Make _subscribe/_subscribe_appliances async and await asyncio.wait_for(asyncio.wrap_future(future), _SUBSCRIBE_TIMEOUT) instead, yielding the loop while keeping the order and the timeout bound. Also use the null-tolerant _subscribed_topics() helper. Tests: watchdog survives a raising _start, propagates CancelledError, backoff grows/resets/caps; subscribe preserves order, yields the loop, honours the timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated release PR for
v2.6.0.Summary by CodeRabbit
Release Notes
Dependencies
Improvements