x86-64 Stack Compression - #647
Merged
Merged
Conversation
linxuanm
force-pushed
the
x86-compression-backend
branch
from
August 25, 2026 22:02
8100734 to
8160ffc
Compare
titzer
reviewed
Aug 26, 2026
| type RelocatableFrame(data: WasmFrameData, is_spc: bool, bytecode_ip: u64) #unboxed { } | ||
| // {bytecode_offset} is the byte offset into {data.func.decl.cur_bytecode} at which the interpreter | ||
| // resumes (unused when {is_spc} is true). | ||
| type RelocatableFrame(data: WasmFrameData, is_spc: bool, bytecode_offset: int) #unboxed { } |
Owner
There was a problem hiding this comment.
Let's use "pc" instead of "bytecode_offset"--that matches the rest of the code.
Contributor
Author
There was a problem hiding this comment.
I believe bytecode_offset is different from pc here. bytecode_offset was initially referring to ip, which differs from pc because a non-top stack in the chain has pc pointed at the start of its resume call while ip is advanced forward. It was initially named bytecode_ip to store the partial ip as a pointer casted to a u64, but this will fail if the cur_bytecodes has been moved by the GC and the bytecode_ip will point to recycled memory after a GC call. Due to this I changed it to store the offset of ip from cur_bytecodes instead. Should I name this to ip_offset or something?
linxuanm
force-pushed
the
x86-compression-backend
branch
from
August 26, 2026 17:18
97f7128 to
650c0ef
Compare
linxuanm
marked this pull request as draft
August 29, 2026 19:50
linxuanm
force-pushed
the
x86-compression-backend
branch
from
August 29, 2026 20:38
efd4f14 to
6f2fb92
Compare
linxuanm
marked this pull request as ready for review
August 31, 2026 03:23
titzer
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack compression backend for
x86-64.