feat(task-board): ✨ Improve composer task board long lists - #145
Merged
Conversation
…ollable task list Introduce a `variant` prop to `TaskBoardCard` for a compact "composer" layout that limits height and enables internal scrolling. The component now shows a progress summary (e.g., "2/8 completed", "1 failed") and the current active task when the list is long or the variant is set to composer. - Add `variant` and `compactThreshold` props to `TaskBoardCard` - Implement `showSummary` logic to display task completion and failure counts - Display the active task description when available - Constrain composer task boards with `max-h-[min(32vh,280px)]` and enable vertical scrolling via `overflow-y-auto` - Move `errorDetail` inside the task description span and display as a block element - Update `RuntimeThreadSurface` to use the composer variant and apply height/max-height constraints - Add unit tests for default, long-list, and composer variant behaviors Closes: #457
AI Code Review SummaryPR: #145 (feat(task-board): ✨ Improve composer task board long lists) Overall AssessmentDetected 1 actionable findings, prioritize CRITICAL/HIGH before merge. Major Findings by Severity
Actionable Suggestions
Potential Risks
Test Suggestions
File-Level Coverage Notes
Inline Downgraded Items (processed but not inline)
Coverage Status
Uncovered list:
No-patch covered list:
Runtime/Budget
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const failedCount = board.tasks.filter((task: TaskItemDto) => task.stage === "failed").length; | ||
| const activeTask = board.tasks.find((task: TaskItemDto) => task.id === board.activeTaskId) ?? getActiveTask(board); | ||
| const isLongList = totalCount > compactThreshold; | ||
| const showSummary = isComposerVariant || isLongList || collapsed; |
There was a problem hiding this comment.
[MEDIUM] showSummary logic causes summary to appear unexpectedly when collapsed
showSummary is true whenever collapsed is true, regardless of board length or variant. This may show a summary row even for short default-variant boards that were previously at their natural collapsed state.
Suggestion: Consider limiting collapsed summary to long lists or composer variant only: const showSummary = isComposerVariant || isLongList || (collapsed && (isComposerVariant || isLongList)); or keep it intentional if UX calls for it, but document the behavior.
Risk: Unintended UI noise / summary row appearing for short default boards when clicked to collapse.
Confidence: 0.85
[From SubAgent: general]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
🤖 Generated with TiyCode