refactor(workbench-shell): ♻️ Hide redundant COMMAND block in shell tool detail view - #148
Merged
Conversation
…entation Added `showCommandBlock: false` to the shell tool presentation configuration to control visibility of the command block in the runtime thread surface.
AI Code Review SummaryPR: #148 (refactor(workbench-shell): ♻️ Hide redundant COMMAND block in shell tool detail view) Overall AssessmentNo blocking issue was detected in the reviewed diff; keep focused regression testing before merge. Major Findings by SeverityNo major issues identified from the reviewed diff. Actionable Suggestions
Potential Risks
Test Suggestions
File-Level Coverage Notes
Inline Downgraded Items (processed but not inline)
Coverage Status
Uncovered list:
No-patch covered list:
Runtime/Budget
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -344,6 +344,7 @@ function getShellToolPresentation(tool: RuntimeSurfaceToolEntry): CommandOutputT | |||
| detailLabel: cwd ? `cwd · ${cwd}` : null, | |||
There was a problem hiding this comment.
Automated review completed for this PR diff. No concrete inline issue was selected after aggregation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showCommandBlock: falseingetShellToolPresentationto eliminate duplicate information and save vertical spaceTest Plan
term_write,term_restart) still show their command blocks as before🤖 Generated with TiyCode