Add maskable icons #1655
Merged
Add maskable icons #1655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnans2006
force-pushed
the
favicon-update
branch
from
2e3e617 to
7b3a8fc
Compare
krishnans2006
force-pushed
the
favicon-update
branch
from
7b3a8fc to
e750c86
Compare
Member
Author
|
For further comparison, here's Ion's current icon vs. Tin's maskable icon (on ChromeOS): |
krishnans2006
changed the title
alanzhu0
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
manifest.jsonBrief description of rationale
Maskable icons are designed for PWAs to support a variety of icon shapes through extra padding. Most notably, they remove the "white border" present around Ion's current icon. Here is a nice comparison:
Technical details
This change introduces new maskable icons for Ion. Here are a few visual representations this icon can take:
They will take effect in the following environments:
For further details, see:
This was inspired by tjcsl/tin@9cf961c.