feat(ui): update UI - #121
Merged
Merged
Conversation
- Add `preferred_language_choice_label` to display numeric choices for language. - Update `normalize_preferred_language_choice` to accept 1/2 as valid input. - Change default for "Mark plan done and archive?" prompt to 'Y/n'. - Provide an example `pnpm install` for "Repo setup command" prompt. - Adjust test cases to reflect updated prompt messages. These changes enhance user experience by making prompts more intuitive and providing helpful defaults or examples, reducing ambiguity and potential for invalid input.
- Change default task expansion to always be true - Update font family variable from `--ui-font-family` to `--app-font-family` - Add test to verify app shell font family configuration The task expansion logic was simplified to always expand tasks, improving visibility of task details by default. The font family variable was renamed for better clarity and consistency across the application. A new test was added to ensure the app shell correctly applies the configured fixed-width font.
- Update color scheme description to include `Light | Dark | System` mode control and four visible family buttons (`dracula`, `nord`, `solarized`, `gruvbox`). - Clarify imagery/iconography to use quiet color dots for status and avoid checkmark glyphs in task headers. - Detail theme select row component to include mode segmented control, family grid, and palette chips. - Revise token/component ownership to specify individual CSS files for different surface types. - Expand on the 2026-06-18 refresh to include the expansion of theme presets to four famous families with dark/light variants. This commit refines the `DESIGN.md` document to provide more precise and updated specifications for the application's visual language, component design, and styling architecture, reflecting recent design decisions. feat(app): add quit_app command and remove tray menu - Implement a new `quit_app` Tauri command to allow programmatic application exit. - Remove the tray icon menu, including "Show Companion" and "Quit" menu items. - Update the Tauri builder to register the new `quit_app` command. This change provides a dedicated command for gracefully exiting the application, which can be triggered from the frontend. The removal of the tray menu simplifies the tray icon's interaction model, as the primary UI is expected to be managed through the main window.
|
Warning Review limit reached
More reviews will be available in 24 minutes and 44 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughThe companion app's single-theme preference is replaced with a ChangesCompanion App: Theme Model, CSS Split, Quit & Tray
CLI Prompt UX: Language, Archive, Repo Setup
Sequence Diagram(s)sequenceDiagram
participant App
participant useSystemThemeMode
participant preferences.ts
participant themePreferences.ts
participant SettingsPanel
App->>useSystemThemeMode: mount
useSystemThemeMode-->>App: systemThemeMode ("light"|"dark")
App->>preferences.ts: resolvedCompanionTheme(preferences, systemThemeMode)
preferences.ts->>themePreferences.ts: resolvedThemeValue(themeFamily, resolvedMode)
themePreferences.ts-->>App: CompanionTheme ("dracula-dark")
App->>App: main[data-theme="dracula-dark"]
App->>SettingsPanel: systemThemeMode prop
SettingsPanel->>SettingsPanel: filter theme options by resolved mode
SettingsPanel->>SettingsPanel: render mode toggle + family button grid with swatches
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
apps/companion/src/styles/task-details.css (1)
23-31: ⚡ Quick winScope
summarystyles to the task surface to prevent style bleed.These selectors are global in a modular CSS setup. Scoping them to task rows avoids accidental overrides if other
summaryelements are introduced elsewhere.Suggested diff
-summary { +.task summary { cursor: default; list-style: none; padding: 9px 10px; } -summary::-webkit-details-marker { +.task summary::-webkit-details-marker { display: none; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/companion/src/styles/task-details.css` around lines 23 - 31, The global `summary` and `summary::-webkit-details-marker` selectors in the task-details.css file are too broad and can cause unintended style overrides elsewhere in the application. Scope these selectors by prefixing them with a task-specific parent container class (such as a task row or task surface container class). For example, change `summary` to `.task-container summary` and `summary::-webkit-details-marker` to `.task-container summary::-webkit-details-marker` to ensure these styles only apply within the task component and do not affect other summary elements in the application.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/companion/src-tauri/src/tray.rs`:
- Around line 82-93: The gate acceptance in click_action_from_tray_event happens
before validating whether the button click maps to a real action. Since
middle-click returns None from click_action_for_button, it still updates
last_accepted_click in the gate, causing subsequent real clicks to be
incorrectly suppressed. Move the gate.accept check to occur only after mapping
the button to a ClickAction using click_action_for_button. If the button does
not map to a valid ClickAction (returns None), return None without consuming the
gate. Only accept the gate and return the action when click_action_for_button
returns Some.
In `@apps/companion/src/styles/chrome.css`:
- Around line 91-96: In the `.toolbar-icon` and `.view-nav-icon` CSS rule,
remove the empty line that appears between the `fill: none;` declaration and the
`stroke: currentcolor;` declaration. This empty line violates the stylelint
`declaration-empty-line-before` rule and should be eliminated by placing
`stroke: currentcolor;` directly after `fill: none;` without any blank lines in
between.
In `@apps/companion/src/styles/settings.css`:
- Around line 73-87: The `.settings-row-select select` selector adds a custom
dropdown arrow using the `::after` pseudo-element but does not hide the native
browser select arrow, causing both arrows to display in some browsers. Add the
`appearance: none;` CSS property to the `.settings-row-select select` rule to
disable the default browser dropdown arrow and ensure only the custom caret is
visible.
In `@apps/companion/tests/app-shell.test.tsx`:
- Around line 7-13: The readCssContract function has unbounded recursion that
can hang on circular `@import` chains because it doesn't track which files have
already been processed. Add cycle protection by introducing a visited files
tracking mechanism, either through an optional parameter or a Set of processed
file paths. Before recursively calling readCssContract for each imported file
path in the .map() function, check if the resolved absolute path has already
been visited, and skip processing if it has. This prevents infinite loops when
CSS files have circular import dependencies.
In `@bin/workbranch`:
- Around line 679-684: The preferred_language_choice_label() function has been
edited directly in bin/workbranch, which violates the repo's build contract.
Locate the source file for this function in src/workbranch/**, apply your
changes to that source file instead of the generated bin/workbranch file, and
then rebuild the bin/workbranch artifact from the source. This also applies to
other locations mentioned in the comment (lines 695, 1965-1968, 3260-3261,
3360-3364) - identify all direct edits in bin/workbranch and move them back to
their corresponding src/workbranch/** sources before regenerating the file.
---
Nitpick comments:
In `@apps/companion/src/styles/task-details.css`:
- Around line 23-31: The global `summary` and `summary::-webkit-details-marker`
selectors in the task-details.css file are too broad and can cause unintended
style overrides elsewhere in the application. Scope these selectors by prefixing
them with a task-specific parent container class (such as a task row or task
surface container class). For example, change `summary` to `.task-container
summary` and `summary::-webkit-details-marker` to `.task-container
summary::-webkit-details-marker` to ensure these styles only apply within the
task component and do not affect other summary elements in the application.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e75d756f-6977-4635-86d5-4d31fdcbd13a
📒 Files selected for processing (37)
DESIGN.mdapps/cli/bin/workbranchapps/cli/src/workbranch/commands/config.shapps/cli/src/workbranch/lib/archive.shapps/cli/src/workbranch/lib/config.shapps/cli/tests/cases/config.shapps/cli/tests/cases/interactive-init.shapps/cli/tests/cases/plan-archive-triggers.shapps/companion/src-tauri/src/lib.rsapps/companion/src-tauri/src/tray.rsapps/companion/src-tauri/src/workbranch_bin.rsapps/companion/src/App.tsxapps/companion/src/application/preferences.tsapps/companion/src/application/state.tsapps/companion/src/application/systemThemeMode.tsapps/companion/src/application/themePreferences.tsapps/companion/src/infrastructure/tauriClient.tsapps/companion/src/style.cssapps/companion/src/styles/base.cssapps/companion/src/styles/chrome.cssapps/companion/src/styles/motion.cssapps/companion/src/styles/settings.cssapps/companion/src/styles/status-groups.cssapps/companion/src/styles/task-details.cssapps/companion/src/styles/themes.cssapps/companion/src/ui/AppToolbar.tsxapps/companion/src/ui/SettingsPanel.tsxapps/companion/src/ui/TaskRow.tsxapps/companion/tests/acl.test.tsapps/companion/tests/app-shell.test.tsxapps/companion/tests/preferences.test.tsapps/companion/tests/settings-panel.test.tsxapps/companion/tests/task-row.test.tsxapps/companion/tests/tauri-client.test.tsapps/companion/tests/view-nav.test.tsxbin/workbranchdocs/plans/0031-current-only-brief-and-plan-archive-lifecycle.md
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 282eb42059
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- The `archive_prompt_current_plan` function now correctly handles an End-of-File (EOF) input by returning 0, preventing unintended behavior when the prompt is closed without user input. - Added a new test case `test_land_archive_prompt_eof_keeps_brief` to verify that an EOF input to the archive prompt results in the plan not being archived. This change ensures that if a user closes the prompt or provides an EOF, the plan is not automatically archived, maintaining the expected state. fix(companion): prevent click gate consumption on middle click - Modified `click_action_from_tray_event` to only consume the click gate if a valid action is determined from the button click. - Added a new test case `middle_click_does_not_consume_click_gate` to ensure that a middle-click event does not consume the tray click gate, allowing subsequent clicks to be processed. This prevents the click gate from being consumed by non-actionable clicks (like middle-click), ensuring that subsequent actionable clicks are not suppressed. refactor(companion): rename legacy theme check - Renamed `isCompanionTheme` to `isLegacyCompanionTheme` in `application/preferences.ts` and `application/themePreferences.ts`. - Updated references to the renamed function in `sanitizeCompanionPreferences`. - Added `PREVIOUS_COMPANION_THEME_VALUES` to explicitly list the old theme values. This refactoring clarifies the distinction between current and legacy theme values, improving code readability and maintainability.
This was referenced Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
UI Improvements