Delegate kSubset semantics to KSubsetValue - #130
Merged
Merged
Conversation
lemmy
force-pushed
the
mku-ksubset
branch
2 times, most recently
from
September 11, 2026 20:09
f8bcbea to
3d08e1b
Compare
lemmy
marked this pull request as ready for review
September 12, 2026 01:36
lemmy
force-pushed
the
mku-ksubset
branch
2 times, most recently
from
September 12, 2026 02:27
52e97e4 to
09d015b
Compare
TLC owns KSubsetValue, so input validation and boundary cases should be handled there. Pass the original set value through instead of eagerly converting it to SetEnumValue, which rejected unenumerable sets such as Nat and STRING. Related to tlaplus/tlaplus Github issue #1415 tlaplus/tlaplus#1415 [Refactor][Tests] Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy
added a commit
to tlaplus/tlaplus
that referenced
this pull request
Sep 12, 2026
FiniteSetsExt!kSubset now preserves a lazy KSubsetValue instead of eagerly enumerating its base. The test dependency must provide this behavior before TLC enables the infinite-base k-subset assumptions. Related to tlaplus/CommunityModules#130 https://github.com/tlaplus/CommunityModules/releases/tag/202609120237 [Build][Tests][TLC] Co-authored-by: GPT-5.6 Sol <noreply@openai.com> Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLC owns KSubsetValue, so input validation and boundary cases should be handled there. Pass the original set value through instead of eagerly converting it to SetEnumValue, which rejected unenumerable sets such as Nat and STRING.
Related to tlaplus/tlaplus Github issue #1415
tlaplus/tlaplus#1415
[Refactor][Tests]