feat(QML): all widgets are now QML components #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All audio widgets are now QML components. This required migrating the delay estimator, the generator, and refactoring the Pitch tracker. The benefit is that now the creation of the visual part of the audio widget is centralized in dock.py, instead of being copied over in every widget. Also, it promotes a clearer separation between viewmodel and view. This will allow to continue the conversion of Friture to be a full QML app. We choose the Fusion style for Qt Quick Controls, used in the Generator view. The Fusion style is appropriate for Desktop apps, and works fine with Dark or White themes as set in the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All audio widgets are now QML components. This required migrating the delay estimator, the generator, and refactoring the Pitch tracker.
The benefit is that now the creation of the visual part of the audio widget is centralized in dock.py, instead of being copied over in every widget. Also, it promotes a clearer separation between viewmodel and view.
This will allow to continue the conversion of Friture to be a full QML app.
We choose the Fusion style for Qt Quick Controls, used in the Generator view. The Fusion style is appropriate for Desktop apps, and works fine with Dark or White themes as set in the system.
We load the QML using QQuickView, which exposes a setInitialProperties method, unlike QQuickWidget. setInitialProperties allows to pass the viewmodel before the component is initialized, which removes the need for the Loader that was used with QQuickWidget.