Skip impossible tests, nose compatibility, test setup #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some OpenSSL builds can only use some of the ECs, so we should skip testing ecdsa if OpenSSL doesn't support the EC. Also, nose seems to detect do_test as a test to be run, so remove _test from the helper functions in the OpenSSL test clases. There is also no need to run openssl version multiple times, so cache the result of the helper function.
tomato42
requested changes
Sep 5, 2018
Member
tomato42
left a comment
tomato42
left a comment
There was a problem hiding this comment.
rebase and listed changes needed
tomato42
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OpenSSL builds can only use some of the ECs, so we should skip testing ecdsa if OpenSSL doesn't support the EC.
Also, nose seems to detect do_test as a test to be run, so remove _test from the helper functions in the OpenSSL test clases.
There is also no need to run openssl version multiple times, so cache the result of the helper function.
fixes #46