Skip to content

feat: add app logo as favicon, navbar brand icon, and README branding#281

Merged
tmseidel merged 3 commits into
developfrom
feature/new-icon
Jul 18, 2026
Merged

feat: add app logo as favicon, navbar brand icon, and README branding#281
tmseidel merged 3 commits into
developfrom
feature/new-icon

Conversation

@tmseidel

Copy link
Copy Markdown
Owner

No description provided.

Replace the generated SVG icon with the new logo (ai-git-bot-new-logo.png):

- favicon.png copied to static/images for browser tab favicon
- layout.html, login.html, setup.html: swap favicon.svg → favicon.png
  (favicon <link> + brand/navbar <img> + login/setup screen logo)
- README.md + translations (JA/KO/ZH): inline logo with h1 title
@clicki-mc-testface

Copy link
Copy Markdown
Collaborator

E2E Test Run for PR #281

🤖 Starting end-to-end test run — this typically takes several minutes.

  • Framework: playwright
  • Suite lifecycle: offer-as-pr

I'll deploy a preview environment, generate the test suite and post the results here when the run finishes. Use @bot rerun-tests to re-execute or @bot regenerate-tests <feedback> to re-plan the suite.

@max-california max-california left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Agentic Code Review

Summary: the UI-side asset swap looks correct and low-risk, but the README heading change introduces a portability/rendering issue in common Markdown viewers. I’d block on the docs change unless that presentation has been verified on the intended platforms.

Blocking

  • README headings are no longer plain Markdown headings
    In README.md:1, README.ja.md:1, README.ko.md:1, and README.zh.md:1, the PR replaces # AI-Git-Bot with an HTML <img .../> embedded directly in the heading.

    This is visually nice on GitHub, but it’s not reliably rendered across Markdown tooling:

    • many Markdown parsers/sanitizers strip inline styles like style="margin-right: 8px;"
    • some renderers handle raw HTML in headings inconsistently
    • some ecosystems derive TOC/anchors/title extraction from plain heading text and can behave oddly with embedded HTML

    Since the repo maintains multiple localized READMEs, this change multiplies that compatibility risk four times for a purely cosmetic benefit.

    Suggestion: keep the heading as plain Markdown and place the logo on the next line, e.g.:

    • plain # AI-Git-Bot
    • then a separate <img ...> or standard Markdown image below it

Non-blocking

  • Consider keeping the SVG favicon for browser tab usage
    The template changes in src/main/resources/templates/layout.html, login.html, and setup.html switch the favicon from favicon.svg to favicon.png, while src/main/resources/static/images/favicon.svg still exists.

    This is not incorrect, but SVG favicons generally scale better and stay sharper across resolutions. If the PNG is specifically needed because the new logo doesn’t work well as SVG, that’s fine; otherwise you may want to either:

    • keep SVG for <link rel="icon"> and use PNG only for <img> tags, or
    • provide both formats for broader compatibility

Overall, the app template changes look straightforward and consistent; the only substantive concern I found is the README heading markup portability.


Read-only agentic review by AI Git Bot

tmseidel added 2 commits July 18, 2026 13:26
Replace the generated SVG icon with the new logo (ai-git-bot-new-logo.png):

- favicon.png copied to static/images for browser tab favicon
- layout.html, login.html, setup.html: swap favicon.svg → favicon.png
  (favicon <link> + brand/navbar <img> + login/setup screen logo)
- README.md + translations (JA/KO/ZH): inline logo with h1 title
Replace the generated SVG icon with the new logo (ai-git-bot-new-logo.png):

- favicon.png copied to static/images for browser tab favicon
- layout.html, login.html, setup.html: swap favicon.svg → favicon.png
  (favicon <link> + brand/navbar <img> + login/setup screen logo)
- README.md + translations (JA/KO/ZH): inline logo with h1 title
Repository owner deleted a comment from clicki-mc-testface Jul 18, 2026
Repository owner deleted a comment from clicki-mc-testface Jul 18, 2026
Repository owner deleted a comment from clicki-mc-testface Jul 18, 2026
Repository owner deleted a comment from clicki-mc-testface Jul 18, 2026
Repository owner deleted a comment from clicki-mc-testface Jul 18, 2026
@tmseidel

Copy link
Copy Markdown
Owner Author

@clicki-mc-testface regenerate-tests

@clicki-mc-testface

Copy link
Copy Markdown
Collaborator

E2E Test Run for PR #281

🤖 Starting end-to-end test run — this typically takes several minutes.

  • Framework: playwright
  • Suite lifecycle: offer-as-pr

I'll deploy a preview environment, generate the test suite and post the results here when the run finishes. Use @bot rerun-tests to re-execute or @bot regenerate-tests <feedback> to re-plan the suite.

@clicki-mc-testface clicki-mc-testface left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E Test Run for PR #281

Framework: playwright
Preview environment: http://46.225.226.81:20047
Source SHA: be1c77a5
Outcome: ⏭️ SKIPPED

No test cases were generated. TestPlannerAgent returned no journeys — nothing to author or run

@tmseidel

Copy link
Copy Markdown
Owner Author

@clicki-mc-testface regenerate-tests Add test that checks for presence of the new logo, first as favicon and second in the navigation bar

@clicki-mc-testface

Copy link
Copy Markdown
Collaborator

E2E Test Run for PR #281

🤖 Starting end-to-end test run — this typically takes several minutes.

  • Framework: playwright
  • Suite lifecycle: offer-as-pr

I'll deploy a preview environment, generate the test suite and post the results here when the run finishes. Use @bot rerun-tests to re-execute or @bot regenerate-tests <feedback> to re-plan the suite.

@clicki-mc-testface clicki-mc-testface left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E Test Run for PR #281

Framework: playwright
Preview environment: http://46.225.226.81:20048
Source SHA: be1c77a5
Outcome: ⏭️ SKIPPED

No test cases were generated. TestPlannerAgent returned no journeys — nothing to author or run

@tmseidel

Copy link
Copy Markdown
Owner Author

@max-california Since our primary target is github we can check if the md-formatting works for github, we don't have the requirment that it should looks the same on every MD-Renderer

@max-california

Copy link
Copy Markdown
Collaborator

🤖 Follow-up

Yes — if GitHub is the only renderer you care about, that weakens the portability concern a lot.

For this PR specifically, the README change is:

# <img src="doc/images/ai-git-bot-new-logo.png" alt="Logo" width="32" align="left" style="margin-right: 8px;"/> AI-Git-Bot

On GitHub, inline HTML in Markdown is generally supported, so the image itself should render. However, I’d still be a bit cautious about relying on the exact layout/styling details:

  • style="margin-right: 8px;" is the most fragile part
  • align="left" is old HTML and may not behave consistently
  • putting an <img> inside a # heading can render, but spacing/alignment may not be exactly what you expect

So my updated take would be:

  • Not a blocker if the team only targets GitHub and you’ve visually checked the README there.
  • Still worth verifying manually on GitHub that the heading looks right, especially spacing and vertical alignment.
  • If GitHub rendering looks off, the safer fallback is a simpler heading image pattern, e.g. image on its own line above the # AI-Git-Bot, or image without inline CSS.

In short: yes, GitHub-only support is a reasonable justification here; just confirm the actual GitHub rendering before merging.


Read-only agentic review follow-up by AI Git Bot

@tmseidel
tmseidel merged commit dd30365 into develop Jul 18, 2026
3 of 4 checks passed
@tmseidel
tmseidel deleted the feature/new-icon branch July 18, 2026 12:08
@tmseidel tmseidel linked an issue Jul 18, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce icon

3 participants