Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #657 +/- ##
===========================================
- Coverage 67.17% 46.55% -20.63%
===========================================
Files 41 22 -19
Lines 4478 2363 -2115
Branches 624 389 -235
===========================================
- Hits 3008 1100 -1908
+ Misses 1240 1094 -146
+ Partials 230 169 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
why: Consolidate docs dependencies into the gp-sphinx shared platform,
replacing individual sphinx extensions with curated package bundles.
what:
- Remove sphinx<9, furo, sphinx-autodoc-typehints, sphinx-inline-tabs,
sphinxext-opengraph, sphinx-copybutton, sphinxext-rediraffe,
sphinx-design, myst-parser, linkify-it-py from dev/docs groups
- Add gp-sphinx and sphinx-pytest-fixtures (editable from local workspace)
- Move types-docutils into dev group (needed for sphinx_pytest_fixtures types)
- Add [tool.uv.sources] pointing to local gp-sphinx packages
- Update uv.lock
why: libtmux was maintaining ~290 lines of Sphinx configuration that
duplicates what gp-sphinx now provides as shared defaults — fonts,
theme, extensions, copybutton, autodoc, and linkcode resolution.
what:
- Replace manual conf.py with merge_sphinx_config() and make_linkcode_resolve()
- Retain project-specific overrides: announcement banner, favicon,
custom CSS, todo extension
…t-fixtures why: Follow sphinx-autodoc-* naming convention (like sphinx-autodoc-typehints). what: - Update dependency name in dev and docs groups - Update [tool.uv.sources] path - Update mypy module override - Update docs/conf.py extra_extensions
why: Match tmuxp's gp-sphinx integration pattern — use git sources pointing to git-pull/gp-sphinx#init-3 instead of local editable paths. sphinx_fonts and sphinx_pytest_fixtures are now gp-sphinx packages. what: - Switch [tool.uv.sources] from local paths to git sources (init-3) - Remove docs/_ext/sphinx_fonts.py (now sphinx-fonts package) - Remove docs/_ext/sphinx_pytest_fixtures/ (now sphinx-autodoc-pytest-fixtures) - Keep docs/_ext/spf_demo_fixtures.py (libtmux-specific badge demo) - Re-add docs/_ext to sys.path for spf_demo_fixtures only
why: sphinx_fonts, sphinx_pytest_fixtures, and their tests now live in the gp-sphinx workspace as independent packages. The badge demo page depended on spf_demo_fixtures which was libtmux-specific scaffolding. what: - Remove docs/_ext/spf_demo_fixtures.py and remaining __pycache__ - Remove tests/docs/_ext/ entirely (tests migrated to gp-sphinx) - Remove docs/demo/ badge showcase pages - Remove demo/index from docs toctree - Remove dead mypy overrides for sphinx_fonts and sphinx_autodoc_pytest_fixtures - Remove _ext sys.path from docs/conf.py
why: Squash incremental git-source tracking into final pinned release. what: - Remove [tool.uv.sources] git overrides for gp-sphinx packages - Pin gp-sphinx==0.0.1a0 and sphinx-autodoc-pytest-fixtures==0.0.1a0 - Update uv.lock to resolve from PyPI
…tmux (first-party)
why: tests/docs/ was a placeholder for upstream extension tests that
were never committed. With sphinx-fonts and sphinx-autodoc-pytest-fixtures
as standalone PyPI packages, there is nothing to test here.
what:
- Remove tests/docs/__init__.py
why: The gp-sphinx docs stack moved to v0.0.1a1 and downstream branches need matching pins and locks. what: - bump gp-sphinx docs dependency pins from 0.0.1a0 to 0.0.1a1 - refresh uv.lock to resolve the published v0.0.1a1 packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gp-sphinxshared configuration platform viamerge_sphinx_config()0.0.1a1Test plan