Smoke test: pin libtmux to tmux-python/libtmux#672#1043
Draft
tony wants to merge 3 commits into
Draft
Conversation
…e test why: Verify libtmux's 0.57.0 parity branch doesn't regress tmuxp before #672 merges. First sync caught a real regression: cursor_x/y were filtered out of the list-panes -F template by an overzealous prefix rule, causing _wait_for_pane_ready to return True instantly. Fixed upstream in libtmux@78f425ab; this PR pins to that commit. what: - Add [tool.uv.sources] pointing libtmux at parity-pt-2 - Regenerate uv.lock
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1043 +/- ##
=======================================
Coverage 81.98% 81.98%
=======================================
Files 28 28
Lines 2548 2548
Branches 485 485
=======================================
Hits 2089 2089
Misses 328 328
Partials 131 131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
why: Pick up upstream scope-gate fixes (mouse_*_flag, scroll_region_*, cursor_*) and the universal-mislabeled token reclassification on tmux-python/libtmux@parity-pt-2. tmuxp's _wait_for_pane_ready still polls cursor_x/y, so its hydration is load-bearing for this PR's smoke-test signal. what: - Regenerate uv.lock against 426b18a6
why: Pick up the rewritten parity-pt-2 history (commit message cleanup + neo.py:53 comment fix). what: - Regenerate uv.lock against 81a021ed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft smoke-test PR pinning libtmux to the
parity-pt-2branch(tmux-python/libtmux#672) via
[tool.uv.sources]. Not for merge —this verifies tmuxp's test suite passes against libtmux 0.57.0 before
that release ships on PyPI.
Findings
The initial sync caught a real regression: libtmux's
scope-aware
-Ftemplate excludedcursor_x/cursor_yfromlist-panesvia an overzealous prefix rule, causing_wait_for_pane_readyto returnTrueinstantly and breakingthe timeout contract. Reported upstream and fixed in
tmux-python/libtmux@78f425ab; this pin tracks that commit and
all 797 tmuxp tests now pass.
Disposition
Close (or rebase onto a PyPI-pinned PR) once libtmux 0.57.0 lands
on PyPI and the standard dependency-constraint bump replaces this
git pin.
Test plan
just testlocally (797 passed, 2 skipped)