-
Notifications
You must be signed in to change notification settings - Fork 234
Unpin pipfile versions #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r state management between releases.
…ch Pipfile.lock entries.
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 74.52% 74.52%
=======================================
Files 5 5
Lines 785 785
Branches 228 228
=======================================
Hits 585 585
Misses 146 146
Partials 54 54
Continue to review full report at Codecov.
|
|
Hi @tony. I think this PR is good for merge and believe that adding Pipfile.lock to keep track of stable environments, while unpinning some versions in Pipfile will make lives much easier. For stable installation, using locked versions in Pipfile.lock: For updatred installation, using unlocked versions and using Pipfile settings: I hope this helps! |
| @@ -1,4 +1,4 @@ | |||
| # -*- coding: utf8 -*- | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was flake8 and the fact that my pull request reduced the coverage. This file came up as the main offender and this was the first thing flake8 pointed out. I figured I would try and update the pull request and see if that improved coverage results, which it did.
|
Thank you. I am fairly new to Pipfile version dependencies and locking.
We may want to update README with this. |
|
I will update the documentation in a PR to follow. I agree that if Pipfiles are present, pipenv usage and how to improve development workflow with it should be addressed to help package maintainers and contributors. Thanks for merging! Glad to be helping. |
Changes:
"make test" generated some warnings, but passes.