Skip to content

Conversation

@rfoliva
Copy link
Contributor

@rfoliva rfoliva commented Oct 4, 2018

Changes:

  • Include .vscode to the list of editors in .gitignore file.
  • Unpin versions of all the packages in Pipfile to help solve conflicts, except for Click and libtmux. Problems were related to Sphinxs and kaptan.
  • Cleaned up Pipfile, by removing duplicate entries from packages in dev-packages section.
  • Updated requirements files to match stable environment from Pipfile.lock.

"make test" generated some warnings, but passes.

@rfoliva rfoliva mentioned this pull request Oct 4, 2018
@codecov-io
Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   74.52%   74.52%           
=======================================
  Files           5        5           
  Lines         785      785           
  Branches      228      228           
=======================================
  Hits          585      585           
  Misses        146      146           
  Partials       54       54
Impacted Files Coverage Δ
tmuxp/workspacebuilder.py 89.09% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a42f19...bf67293. Read the comment docs.

@rfoliva
Copy link
Contributor Author

rfoliva commented Oct 5, 2018

Hi @tony.

I think this PR is good for merge and believe that adding Pipfile.lock to keep track of stable environments, while unpinning some versions in Pipfile will make lives much easier.

For stable installation, using locked versions in Pipfile.lock:
$ pipenv install --ignore-pipfile --dev

For updatred installation, using unlocked versions and using Pipfile settings:
$ pipenv install --skip-lock --dev

I hope this helps!

@@ -1,4 +1,4 @@
# -*- coding: utf8 -*-
# -*- coding: utf-8 -*-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was flake8 and the fact that my pull request reduced the coverage. This file came up as the main offender and this was the first thing flake8 pointed out. I figured I would try and update the pull request and see if that improved coverage results, which it did.

@tony
Copy link
Member

tony commented Oct 5, 2018

Thank you. I am fairly new to Pipfile version dependencies and locking.

For stable installation, using locked versions in Pipfile.lock:
$ pipenv install --ignore-pipfile --dev

For updatred installation, using unlocked versions and using Pipfile settings:
$ pipenv install --skip-lock --dev

We may want to update README with this.

@tony tony merged commit 8aeeed6 into tmux-python:master Oct 5, 2018
@rfoliva rfoliva deleted the unpin-pipfile-versions branch October 6, 2018 03:56
@rfoliva
Copy link
Contributor Author

rfoliva commented Oct 6, 2018

I will update the documentation in a PR to follow. I agree that if Pipfiles are present, pipenv usage and how to improve development workflow with it should be addressed to help package maintainers and contributors.

Thanks for merging! Glad to be helping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants