Skip to content

Conversation

@rfoliva
Copy link
Contributor

@rfoliva rfoliva commented Oct 6, 2018

  • Include section on pipenv.
  • Clean up .rst files with trailing spaces, long lines and inconsistent section headers.

@codecov-io
Copy link

Codecov Report

Merging #438 into master will decrease coverage by 0.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage    74.9%   74.39%   -0.51%     
==========================================
  Files           5        5              
  Lines         785      785              
  Branches      228      228              
==========================================
- Hits          588      584       -4     
- Misses        145      148       +3     
- Partials       52       53       +1
Impacted Files Coverage Δ
tmuxp/workspacebuilder.py 88.48% <0%> (-2.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aeeed6...78c43ea. Read the comment docs.

@rfoliva
Copy link
Contributor Author

rfoliva commented Oct 6, 2018

Updated doc on Pipenv ready for merge @tony .

@tony
Copy link
Member

tony commented Oct 7, 2018

Nice! @rfoliva

Aside: Would you like maintainer privileges for tmuxp/libtmux? I'm looking to expand so more can participate

@rfoliva
Copy link
Contributor Author

rfoliva commented Oct 8, 2018

@tony - I would be very happy to help.

Thanks for the extending the invitation!

@tony tony merged commit 4314d2a into tmux-python:master Oct 8, 2018
@tony
Copy link
Member

tony commented Oct 8, 2018

@rfoliva Invited.

@rfoliva rfoliva deleted the pipenv-update-doc branch October 8, 2018 15:06
@rfoliva
Copy link
Contributor Author

rfoliva commented Oct 8, 2018

@tony - Thanks.... I will start taking a look into it this evening. Thanksgiving weekend here in Canada! :)

@tony
Copy link
Member

tony commented Oct 8, 2018

@rfoliva Sounds good. Enjoy your holiday! :)

@rfoliva
Copy link
Contributor Author

rfoliva commented Oct 9, 2018

@tony I checked and it seems I need to be given Admin or at least Write permissions in order to be able to handle issues and PRs within the organization.

Here is the link for reference:
https://help.github.com/articles/repository-permission-levels-for-an-organization/

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants