Skip to content

Set requirements to something that will yield a working setup in a clean env.#156

Closed
smarr wants to merge 1 commit into
tobami:masterfrom
smarr:patch-1
Closed

Set requirements to something that will yield a working setup in a clean env.#156
smarr wants to merge 1 commit into
tobami:masterfrom
smarr:patch-1

Conversation

@smarr

@smarr smarr commented Nov 10, 2013

Copy link
Copy Markdown
Contributor

I was struggling quite a bit to find a working combination of things, and this selection of versions seems to do the trick.

It's restrictive, but perhaps good to keep around in case other people not familiar with these frameworks also try to setup Codespeed. I failed with Django 1.4, and 1.6. From the 1.5 line, other versions might work as well. And mimeparse wasn't a requirement before, but was a missing import.

… environment.

I was struggling quite a bit to find a working combination of things, and this selection of versions seems to do the trick.

It's restrictive, but perhaps good to keep around in case other people not familiar with these frameworks also try to setup Codespeed. I failed with Django 1.4, and 1.6. From the 1.5 line, other versions might work as well. And mimeparse wasn't a requirement before, but was a missing import.
@tobami

tobami commented Nov 12, 2013

Copy link
Copy Markdown
Owner

This is weird, as I have a virtualenv with Django 1.4 and tests and views work. Did those problems occur under current master? That is, after the version pinning was changed? That said, again upgrading django, breaks tests in that same virtualenv, reverting to 1.4 doesn't fix them.

The tastypie dependency has only given us grief. What I am proposing to do:

  • Close this pull request
  • Branch into tastypie-api from current master (which works in some cases, though not clear for which)
  • Remove tastypie completely
  • Fix any incompatibilities with any Django version 1.4+
  • Release codespeed 1.0

Anyone opposed to that plan?

@smarr

smarr commented Nov 12, 2013

Copy link
Copy Markdown
Contributor Author

I was using the latest master branch (against which the pull request should be, I think). The deployment seems to work, didn't notice anything broken in my deployment. (http://som-speed.stefan-marr.de/comparison/)

Closing the pull request is fine with me. Just wanted to make you aware that there seem to be issues with a fresh environment. And with respect to the best way forward, good question, but I haven't followed recent developments closely enough to answer it, sorry.

@tobami

tobami commented Nov 13, 2013

Copy link
Copy Markdown
Owner

OK, great. I merged #157, so you could check with master again.

@tobami tobami closed this Nov 13, 2013
@smarr smarr deleted the patch-1 branch December 31, 2017 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants