Fix authentication helper so it works with newer versions of Django (Django 2+)#276
Merged
Merged
Conversation
where "request.user.is_authentication" variable is a property and not a method (aka newer Django versions.)
Contributor
Author
|
I've added some mock based test cases in bed3f63. |
Contributor
Author
|
@tobami When you get a chance, please let me know if there is anything else I need to do. Thanks! |
tobami
reviewed
Feb 16, 2020
tobami
approved these changes
Feb 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I installed recommended version of Django (aka one which is specified in
requirements.txt), yet the/result/add/json/API endpoint returns an error when enabling authentication for that API endpoint (settingALLOW_ANONYMOUS_POSTconfig value toFalse).Here is the error / exception:
Environment:
Looking at the Django changelog, this behavior (method to attribute / property) changed in Django 2 which is installed by CodeSpeed by default (as per
requirements.txt).I assume this issue was never caught because no one who had authentication enabled ran CodeSpeed under Django 2+(?).
This pull request updates the authentication helper so it works with both versions of Django - one where that variable is a method (old versions) and one where it's a property (newer versions).
TODO