Support authenticated Github API requests#278
Merged
Conversation
This comes handy in a lot of scenarios because unauthenticated Github requests have low rate limits.
Kami
commented
Feb 13, 2020
| # Python 2 | ||
| from urllib import urlopen | ||
| from urllib2 import urlopen | ||
| from urllib2 import Request |
Contributor
Author
There was a problem hiding this comment.
I didn't want to introduce additional dependency (requests), so I just followed the existing approach.
Owner
|
We need to start documenting this at least in the readme... |
Contributor
Author
|
@tobami - I agree, where should I add those docs? Should I add it to REAME under "provider" / backend specific settings section / similar? Or to the wiki? Talking about the "backend specific settings" - I didn't want to go overboard since currently there really isn't any other provider specific setting so I just used a plain string value (I didn't want to introduce some kind of dict with per provider / backend options or similar). |
Owner
|
Cool. As a first iteration the same "provider" docs could be added to both the readme and wiki |
This was referenced Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the code so it supports oAuth token authenticated requests to the Github API inside the Github repo provider.
Background / Description
Right now Github provider utilizes non-authenticated Github API requests.
Those requests have a low rate limits set which means Github API will start returning 403 rate limit reached in case the rate limits have been hit (e.g. results for larger number commits are submitted in a short time frame).