Allow user to configure which tags to display on the comparison page#284
Merged
Conversation
executables list. This comes handy in scenarios where there are a lot of tags, but you only want to list / include some of them. NOTE: For backward compatibility reasons, default value is None which means include all the tags.
tobami
requested changes
Mar 11, 2020
Owner
tobami
left a comment
tobami
left a comment
There was a problem hiding this comment.
Nice, this should make the comparison view more usable with lots of tags
Contributor
Author
|
@tobami Thanks for the review. I pushed changes which address that feedback. |
tobami
approved these changes
Mar 25, 2020
Owner
|
Thanks a mil! merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new
COMPARISON_TAGSsetting which allows user to configure which tags to include in the executables list on the comparison page.This comes handy in scenario where a project contains a lot of tags, but you only want to include subset of them on a comparison page.
For backward compatibility reasons, default value is
Nonewhich means include all the tags (same as the previous / existing behavior).Note On Settings Location
Right now some settings are configured via database models and other via settings.py. It would be nice to eventually come up with some convention on what setting to put where.
In reality,
settings.pyis a bit better from infrastructure as code perspective, but it's also possible to achieve the same end "infrastructure as code" result by version controlling model fixtures / migrations in the repository and inserting / running them on code deploy step.