Lint with MRI and Spinel; require both implementations - #133
Merged
Conversation
This was referenced Aug 13, 2026
Warn (don't fail) when spinel is missing. ruby -c always; spinel -c try.rb when present. AGENTS.md now says try must run on MRI and Spinel.
lib/fuzzy.rb and lib/tui.rb compile standalone. Minitest files do not (and are not Spinel programs).
When Spinel is present, rake builds dist/try.c, cc's it to dist/try, runs the full spec suite on the binary, and diffs outputs against MRI. Init's ruby-vs-$0 prefix is normalized; everything else must match exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #131.
rake lintrunsruby -contry.rbandlib/**/*.rbalways.spinelis onPATH(orSPINEL=/path/to/spinel), it also runsspinel -c try.rb(entrypoint pulls in lib viarequire_relative).rake/rake testnow run lint before unit+spec.AGENTS.md: try must keep working on both MRI and Spinel AOT. Prefer Spinel-friendly Ruby or an MRI-compatible shim.
Test plan
PATH=/workspace/spinel/bin:$PATH rake lint— ruby -c + spinel -cPATH=/usr/bin:/bin rake lint— ruby -c + warnings, exit 0