fix(duckdb,postgres,redshift,snowflake)!: ARRAY_CAT null propagation #6829
Merged
Conversation
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 10944 total, 9903 passed (pass rate: 90.5%), sqlglot version: sqlglot:mlee/transpile-array_cat: 10944 total, 9903 passed (pass rate: 90.5%), sqlglot version: Difference: No change |
Collaborator
|
FYI @fivetran-MichaelLee CI's failing for formatting-related reasons. Drop a ping when ready. |
Collaborator
Author
|
@georgesittas This is going to need some more work so I'm keeping in draft for now |
added 2 commits
January 22, 2026 12:03
georgesittas
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support for
ARRAY_CATnull propagation in dialects:Bug Fix
DuckDB's
LIST_CONCATfunction accepts variadic arguments but this was not recognized bysqlglot. RemovedARRAY_CONCAT_IS_VAR_LEN = Falsefrom the dialect and updated tests accordingly.Edge Case Not Handled
Postgres ignores
NULLarguments toARRAY_CAT, but when all arguments areNULLit will returnNULL. When transpiling to a null propagating dialect, the resulting sql willCOALESCEall the arguments to an empty array. Handling this edge case would add to an already complex solution.