fix(presto): respect date part boundary semantics in DATE_DIFF transpilation - #7911
Merged
Conversation
…ilation
Fixes BigQuery `DATETIME_DIFF` (and improves `DATE_DIFF` Snowflake, MySQL diffs) transpilation to Presto/Trino. Presto's `DATE_DIFF` counts complete units while BigQuery, Snowflake, MySQL count boundary crossings, so the Presto generator now truncates both operands to the unit when `date_part_boundary` is set, with a day-shift to realign Presto's Monday-based `DATE_TRUNC('WEEK')` to the requested week start.
geooo109
approved these changes
Jul 20, 2026
Contributor
SQLGlot Integration Test Results✅ All tests passedComparing: Overallmain: 192414 total, 153544 passed (pass rate: 79.8%) sqlglot:jo/date_diff_boundary_fix: 188352 total, 150240 passed (pass rate: 79.8%) Transitions: Dialect pair changes: 0 previous results not found, 1 current results not found ✅ All tests passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BigQuery
DATETIME_DIFF(and improvesDATE_DIFFSnowflake, MySQL diffs) transpilation to Presto/Trino. Presto'sDATE_DIFFcounts complete units while BigQuery, Snowflake, MySQL count boundary crossings, so the Presto generator now truncates both operands to the unit whendate_part_boundaryis set, with a day-shift to realign Presto's Monday-basedDATE_TRUNC('WEEK')to the requested week start.