feat: support "replace using" for insert DML - #7950
Conversation
|
@nlpersimon any plans to finish this? |
yes. appreciate your comment! |
|
closing this for now, feel free to reopen when ready. |
|
Hi @georgesittas @geooo109 , I am ready, could you reopen this PR? Or should I open a new PR? |
|
@nlpersimon go for it |
|
@geooo109 I implemented the support for "replace on" in 1480c2c . I thought it was a trivial work that I can just implement it as elif self._match(TokenType.ON):
replace_on = self._parse_disjunction()
if replace_on is None:
self.raise_error("Expected a condition after REPLACE ON")but this implementation cannot handle the following query INSERT INTO TABLE students AS t
REPLACE ON t.name <=> s.name
(SELECT * FROM people) AS sbecause the parser regards The solution I came up with is implementing a method |
|
@nlpersimon thanks for trying to solve the |
This reverts commit 1480c2c.
reverted. thank you! |
To fix #7949