fix(executor): preserve unmatched outer join rows [CODEX] - #7953
Merged
tobymao merged 1 commit intoJul 27, 2026
Conversation
PiyaDaswadkar
pushed a commit
to PiyaDaswadkar/sqlglot
that referenced
this pull request
Jul 29, 2026
Co-authored-by: dev-willbird1936 <dev-willbird1936@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7952.
The Python executor previously filtered join candidates after constructing the join result. That loses preserved-side rows when a complete
ONcondition rejects a candidate, and it cannot synthesize both sides of a FULL JOIN.This change evaluates the complete
ONcondition while constructing hash and nested-loop joins, tracks matched row indexes, and appends the required null-extended rows for LEFT, RIGHT, and FULL joins. One reusable condition context avoids per-pair setup cost.Tests cover a disjoint FULL JOIN, a LEFT JOIN with a rejecting residual predicate, and nearby valid non-equi inner-join behavior.
Validation:
python -m unittest tests.test_executor.TestExecutor.test_outer_joins_preserve_unmatched_rowspython -m unittest tests.test_executor(22 passed)LLM disclosure: Codex assisted with validation, review, and preparation of this contribution. I reviewed the final behavior, tests, and diff and take responsibility for the submission.