Skip to content

feat(optimizer)!: annotate bit_or for mysql - #8047

Merged
geooo109 merged 2 commits into
tobymao:mainfrom
PiyaDaswadkar:piya/annotate-function-bit_or
Aug 5, 2026
Merged

feat(optimizer)!: annotate bit_or for mysql#8047
geooo109 merged 2 commits into
tobymao:mainfrom
PiyaDaswadkar:piya/annotate-function-bit_or

Conversation

@PiyaDaswadkar

Copy link
Copy Markdown
Contributor

Comment thread sqlglot/typing/mysql.py Outdated
Comment on lines +174 to +176
exp.BitwiseAndAgg: {"annotator": _annotate_bit_func},
exp.BitwiseXorAgg: {"annotator": _annotate_bit_func},
exp.BitwiseOrAgg: {"annotator": _annotate_bit_func},

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do a simple **{...} like other annotators

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated to use the same **{...} pattern as the other annotators

@geooo109
geooo109 merged commit 445d04f into tobymao:main Aug 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants