[rust-toolchain] Use rust-toolchain file to specify toolchain and version #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Woyten
reviewed
Feb 24, 2018
| @@ -0,0 +1 @@ | |||
| nightly-2017-08-16 | |||
Contributor
There was a problem hiding this comment.
On our fork of libtock-rs the latest working compiler version is nightly-2017-12-16. If we pick a version above, xargo stops working. I guess, the problem is that xargo is relying on some specific internal behavior of cargo regarding working directories.
Contributor
There was a problem hiding this comment.
We now fixed the reliance on this specific version on our fork. Moreover, this also fixes #12 which likely comes from incompatibility of the new version of the allocator with the provided nightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use rust-toolchain file to specify toolchain
This closes #10