Skip to content

[rust-toolchain] Use rust-toolchain file to specify toolchain and version #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2018
Merged

[rust-toolchain] Use rust-toolchain file to specify toolchain and version #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rust-toolchain
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
nightly-2017-08-16
Copy link
Contributor

@Woyten Woyten Feb 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On our fork of libtock-rs the latest working compiler version is nightly-2017-12-16. If we pick a version above, xargo stops working. I guess, the problem is that xargo is relying on some specific internal behavior of cargo regarding working directories.

Copy link
Contributor

@torfmaster torfmaster Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now fixed the reliance on this specific version on our fork. Moreover, this also fixes #12 which likely comes from incompatibility of the new version of the allocator with the provided nightly.