Skip to content

refactor(edgeless): abstract pie menu rendering logic #6553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
doouding merged 3 commits into from
Mar 26, 2024
Merged

refactor(edgeless): abstract pie menu rendering logic #6553

doouding merged 3 commits into from
Mar 26, 2024

Conversation

@golok727
Copy link
Contributor

@golok727 golok727 commented Mar 24, 2024 •
edited
Loading

Changes

  • Abstracts all the rendering logic in the PieNode class
  • Remove Unnecessary comments
  • Viewport should not pan when the pie menu is open

@vercel
Copy link

vercel bot commented Mar 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 2:32am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 2:32am

@doodlewind doodlewind requested a review from doouding March 24, 2024 15:47
doouding
doouding requested changes Mar 25, 2024
View reviewed changes
@golok727 golok727 requested a review from doouding March 25, 2024 07:11
doouding
doouding approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@doouding doouding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work :)

@doouding doouding enabled auto-merge (squash) March 26, 2024 02:26
@doouding doouding disabled auto-merge March 26, 2024 02:28
@doouding doouding added the merge label Mar 26, 2024
@graphite-app
Copy link

graphite-app bot commented Mar 26, 2024 •
edited
Loading

Merge activity

@graphite-app graphite-app bot removed the merge label Mar 26, 2024
@doouding doouding merged commit 3bbf851 into toeverything:master Mar 26, 2024
@golok727 golok727 deleted the refactor/pie branch March 26, 2024 02:58
@EYHN EYHN mentioned this pull request Apr 3, 2024
Merged
darkskygit pushed a commit to toeverything/AFFiNE that referenced this pull request Apr 10, 2024
@EYHN
chore: bump blocksuite (#6448)
c92bec0 
## Features
- toeverything/blocksuite#6679 @pengx17
- toeverything/blocksuite#6620 @doouding
- toeverything/blocksuite#6602 @golok727
- toeverything/blocksuite#6661 @Flrande
- toeverything/blocksuite#6591 @fundon
- toeverything/blocksuite#6634 @golok727
- toeverything/blocksuite#6626 @regischen
- toeverything/blocksuite#6630 @Saul-Mirone
- toeverything/blocksuite#6605 @donteatfriedrice
- toeverything/blocksuite#6614 @zzj3720
- toeverything/blocksuite#6508 @doouding
- toeverything/blocksuite#6578 @donteatfriedrice
- toeverything/blocksuite#6572 @zzj3720
- toeverything/blocksuite#6571 @golok727
- toeverything/blocksuite#6573 @fundon
- toeverything/blocksuite#6580 @Flrande
- toeverything/blocksuite#6540 @golok727
- toeverything/blocksuite#6567 @Flrande
- toeverything/blocksuite#6565 @zzj3720
- toeverything/blocksuite#6561 @zzj3720

## Bugfix
- toeverything/blocksuite#6677 @donteatfriedrice
- toeverything/blocksuite#6681 @fundon
- toeverything/blocksuite#6673 @fundon
- toeverything/blocksuite#6652 @fundon
- toeverything/blocksuite#6641 @fourdim
- toeverything/blocksuite#6649 @golok727
- toeverything/blocksuite#6648 @doouding
- toeverything/blocksuite#6662 @Flrande
- toeverything/blocksuite#6659 @zkwolf
- toeverything/blocksuite#6644 @doouding
- toeverything/blocksuite#6633 @golok727
- toeverything/blocksuite#6632 @golok727
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6600 @fourdim
- toeverything/blocksuite#6617 @zzj3720
- toeverything/blocksuite#6618 @Flrande
- toeverything/blocksuite#6576 @fundon
- toeverything/blocksuite#6595 @fundon
- toeverything/blocksuite#6596 @zzj3720
- toeverything/blocksuite#6574 @fundon
- toeverything/blocksuite#6593 @Saul-Mirone
- toeverything/blocksuite#6588 @zzj3720
- toeverything/blocksuite#6590 @zzj3720
- toeverything/blocksuite#6589 @zzj3720
- toeverything/blocksuite#6584 @lawvs
- toeverything/blocksuite#6579 @fundon
- toeverything/blocksuite#6538 @golok727
- toeverything/blocksuite#6570 @zzj3720
- toeverything/blocksuite#6569 @zzj3720
- toeverything/blocksuite#6564 @zzj3720
- toeverything/blocksuite#6563 @zzj3720

## Refactor
- toeverything/blocksuite#6683 @doodlewind
- toeverything/blocksuite#6668 @Flrande
- toeverything/blocksuite#6635 @donteatfriedrice
- toeverything/blocksuite#6653 @fundon
- toeverything/blocksuite#6615 @Flrande
- toeverything/blocksuite#6534 @Saul-Mirone
- toeverything/blocksuite#6553 @golok727

## Misc
- chore(examples): cleanup types
- toeverything/blocksuite#6664 @fourdim
- toeverything/blocksuite#6657 @fourdim
- toeverything/blocksuite#6654 @fourdim
- toeverything/blocksuite#6587 @Saul-Mirone
- toeverything/blocksuite#6562 @donteatfriedrice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doouding doouding doouding approved these changes

Assignees

No one assigned

Labels

None yet

Projects

BlockSuite Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@golok727 @doouding