Skip to content

feat(database): column stats #6560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zzj3720 merged 25 commits into from
Apr 10, 2024
Merged

feat(database): column stats #6560

zzj3720 merged 25 commits into from
Apr 10, 2024

Conversation

@golok727
Copy link
Contributor

@golok727 golok727 commented Mar 25, 2024 •
edited
Loading

image
image
image
image
image

@golok727 golok727 marked this pull request as draft March 25, 2024 06:20
@vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ❌ Failed (Inspect) Apr 10, 2024 3:02pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 3:02pm

@golok727 golok727 force-pushed the feat/database-cell-ops branch from 5ea4604 to 2833016 Compare March 25, 2024 08:24
@zzj3720 zzj3720 mentioned this pull request Mar 28, 2024
Closed
1 task
@golok727
Copy link
Contributor Author

golok727 commented Apr 4, 2024 •
edited
Loading

@zzj3720 Hey some help🙏🏻, why does datasource.onCellUpdate is inconsistent with different property types? rich text and title is using ytext observe and others are using model.propsChanges in data source. due to this the callback given to onCellUpdate is called for all the columns when a cell is updated. Also is it not getting called for richtext cells.
Is this intended behaviour as I only want to compute the stats for the updated columns

@zzj3720
Copy link
Member

zzj3720 commented Apr 10, 2024

@zzj3720 Hey some help🙏🏻, why does datasource.onCellUpdate is inconsistent with different property types? rich text and title is using ytext observe and others are using model.propsChanges in data source. due to this the callback given to onCellUpdate is called for all the columns when a cell is updated. Also is it not getting called for richtext cells. Is this intended behaviour as I only want to compute the stats for the updated columns

Listening for updates on columns is challenging; I need to think about it.

@zzj3720
Copy link
Member

zzj3720 commented Apr 10, 2024

@golok727 I think we can temporarily set aside the issue of listening for updates on the title column and fix it later. If the statistics functionality is completed, we can add a feature flag to merge it first and then optimize it. I might be doing some adjustments and refactoring to the directory structure soon, so if this task drags on too long, it might be difficult to merge.

@golok727
Copy link
Contributor Author

golok727 commented Apr 10, 2024

@golok727 I think we can temporarily set aside the issue of listening for updates on the title column and fix it later. If the statistics functionality is completed, we can add a feature flag to merge it first and then optimize it. I might be doing some adjustments and refactoring to the directory structure soon, so if this task drags on too long, it might be difficult to merge.

The core functionality is finished; I'll refine it by making the statCalcOp optional, integrating the feature flag as discussed, and ensuring the PR is ready for review by this evening. Thanks!

@golok727 golok727 force-pushed the feat/database-cell-ops branch from 0f0db47 to d80a2e6 Compare April 10, 2024 09:24
@golok727 golok727 force-pushed the feat/database-cell-ops branch from d80a2e6 to 6f96082 Compare April 10, 2024 09:29
@golok727 golok727 marked this pull request as ready for review April 10, 2024 10:05
@Saul-Mirone
Copy link
Collaborator

Saul-Mirone commented Apr 10, 2024

Waiting for @zzj3720 to review this.

@golok727 golok727 requested a review from zzj3720 April 10, 2024 12:23
@zzj3720 zzj3720 added the merge label Apr 10, 2024
@graphite-app
Copy link

graphite-app bot commented Apr 10, 2024 •
edited
Loading

Merge activity

  • Apr 10, 11:02 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 10, 11:08 AM EDT: zzj3720 added this pull request to the Graphite merge queue.
  • Apr 10, 11:12 AM EDT: The Graphite merge queue wasn't able to merge this pull request due to internal failures.
  • Apr 10, 11:12 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 10, 11:12 AM EDT: zzj3720 added this pull request to the Graphite merge queue.
  • Apr 10, 3:12 PM UTC: graphite-app removed this pull request from the Graphite merge queue.
  • Apr 10, 3:12 PM UTC: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue

@graphite-app graphite-app bot removed the merge label Apr 10, 2024
@zzj3720 zzj3720 merged commit e5393ec into toeverything:master Apr 10, 2024
@golok727 golok727 deleted the feat/database-cell-ops branch April 10, 2024 15:19
fundon pushed a commit that referenced this pull request Apr 11, 2024
@golok727 @zzj3720 @fundon
feat(database): column stats (#6560)
68a7d1a 
Co-authored-by: 3720 <zuozijian1994@gmail.com>
fundon pushed a commit that referenced this pull request Apr 11, 2024
@golok727 @zzj3720 @fundon
feat(database): column stats (#6560)
612dcf5 
Co-authored-by: 3720 <zuozijian1994@gmail.com>
fundon pushed a commit that referenced this pull request Apr 11, 2024
@golok727 @zzj3720 @fundon
feat(database): column stats (#6560)
9febc64 
Co-authored-by: 3720 <zuozijian1994@gmail.com>
@pengx17 pengx17 mentioned this pull request Apr 11, 2024
Merged
EYHN pushed a commit to toeverything/AFFiNE that referenced this pull request Apr 12, 2024
@pengx17
chore(core): bump blocksuite (#6525)
1697cd7 
## Features
- toeverything/blocksuite#6728 @fundon
- toeverything/blocksuite#6714 @doouding
- toeverything/blocksuite#6733 @pengx17
- toeverything/blocksuite#6560 @golok727
- toeverything/blocksuite#6727 @pengx17
- toeverything/blocksuite#6645 @regischen
- toeverything/blocksuite#6724 @fundon
- toeverything/blocksuite#6719 @zzj3720
- toeverything/blocksuite#6682 @donteatfriedrice

## Bugfix
- toeverything/blocksuite#6734 @Flrande
- toeverything/blocksuite#6732 @fourdim
- toeverything/blocksuite#6726 @pengx17
- toeverything/blocksuite#6721 @Flrande
- toeverything/blocksuite#6725 @fundon
- toeverything/blocksuite#6716 @golok727
- toeverything/blocksuite#6723 @donteatfriedrice
- toeverything/blocksuite#6722 @pengx17
- toeverything/blocksuite#6718 @donteatfriedrice
- toeverything/blocksuite#6702 @Tzyito
- toeverything/blocksuite#6711 @Tzyito
- toeverything/blocksuite#6694 @fundon
- toeverything/blocksuite#6717 @golok727

## Refactor
- toeverything/blocksuite#6672 @Saul-Mirone

## Misc
- toeverything/blocksuite#6720 @raintoway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zzj3720 zzj3720 zzj3720 approved these changes

@Saul-Mirone Saul-Mirone Awaiting requested review from Saul-Mirone

@doodlewind doodlewind Awaiting requested review from doodlewind

Assignees

No one assigned

Labels

None yet

Projects

BlockSuite Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@golok727 @zzj3720 @Saul-Mirone