fix(page): the imported markdown file name is displayed by default #6702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
fourdim
approved these changes
Apr 9, 2024
Collaborator
fourdim
left a comment
fourdim
left a comment
There was a problem hiding this comment.
No worries. These two buttons have the same effect.
Merge activity
|
Tzyito
force-pushed
the
block/import-md-name
branch
from
21cdb13 to
63ee274
Compare
Collaborator
|
No worries. CC @doodlewind to merge it manually. |
CatsJuice
reviewed
Apr 9, 2024
| const pageIds: string[] = []; | ||
| for (const file of files) { | ||
| const text = await file.text(); | ||
| const [fileName] = file.name.split('.'); |
Member
There was a problem hiding this comment.
Maybe file.name.split('.').slice(0, -1).join('.') would be more accurate?
Contributor
Author
There was a problem hiding this comment.
thanks for your reply!
EYHN
pushed a commit
to toeverything/AFFiNE
that referenced
this pull request
Apr 12, 2024
## Features - toeverything/blocksuite#6728 @fundon - toeverything/blocksuite#6714 @doouding - toeverything/blocksuite#6733 @pengx17 - toeverything/blocksuite#6560 @golok727 - toeverything/blocksuite#6727 @pengx17 - toeverything/blocksuite#6645 @regischen - toeverything/blocksuite#6724 @fundon - toeverything/blocksuite#6719 @zzj3720 - toeverything/blocksuite#6682 @donteatfriedrice ## Bugfix - toeverything/blocksuite#6734 @Flrande - toeverything/blocksuite#6732 @fourdim - toeverything/blocksuite#6726 @pengx17 - toeverything/blocksuite#6721 @Flrande - toeverything/blocksuite#6725 @fundon - toeverything/blocksuite#6716 @golok727 - toeverything/blocksuite#6723 @donteatfriedrice - toeverything/blocksuite#6722 @pengx17 - toeverything/blocksuite#6718 @donteatfriedrice - toeverything/blocksuite#6702 @Tzyito - toeverything/blocksuite#6711 @Tzyito - toeverything/blocksuite#6694 @fundon - toeverything/blocksuite#6717 @golok727 ## Refactor - toeverything/blocksuite#6672 @Saul-Mirone ## Misc - toeverything/blocksuite#6720 @raintoway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6666 & toeverything/AFFiNE#6460
This will make the file as doc default name when uploading markdown files. But I’m not sure if I need to do this when uploading other types of files.
(btw: One thing I'm confused about is whether these two buttons have the same effect.
