Skip to content

Conversation

@fourdim
Copy link
Collaborator

@fourdim fourdim commented Apr 12, 2024

This closes #6638.

@vercel
Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 2:29am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 2:29am

Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add test for this?

@fourdim fourdim added the test needed Should provide test cases altogether label Apr 12, 2024
@fourdim fourdim requested a review from Saul-Mirone April 15, 2024 02:20
@Saul-Mirone Saul-Mirone added merge and removed test needed Should provide test cases altogether labels Apr 15, 2024
@graphite-app
Copy link

graphite-app bot commented Apr 15, 2024

Merge activity

  • Apr 14, 10:25 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 14, 10:29 PM EDT: Saul-Mirone added this pull request to the Graphite merge queue.
  • Apr 14, 10:32 PM EDT: The Graphite merge queue wasn't able to merge this pull request due to internal failures.
  • Apr 15, 12:55 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 15, 12:56 AM EDT: fourdim added this pull request to the Graphite merge queue.
  • Apr 15, 12:59 AM EDT: The Graphite merge queue wasn't able to merge this pull request due to internal failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'type')

2 participants