Skip to content

Fix line count for epochs - #149

Merged
justusc merged 1 commit into
mainfrom
orangetin/line-count-fix
Jun 27, 2023
Merged

Fix line count for epochs#149
justusc merged 1 commit into
mainfrom
orangetin/line-count-fix

Conversation

@orangetin

Copy link
Copy Markdown
Contributor

No description provided.

@orangetin
orangetin requested a review from justusc June 27, 2023 21:36
@justusc
justusc merged commit 8f2ab8f into main Jun 27, 2023
@justusc
justusc deleted the orangetin/line-count-fix branch June 27, 2023 21:39
for jsonl_file in self.task_names:
with open(jsonl_file, "r") as file:
for line in file:
if line.replace(" ", "") != "\n":

@csris csris Jun 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orangetin, is this trying to do this:

if line.strip() != "":

or this?

if len(line.strip()) > 0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants