Fix race in server-close test that flaked on Windows.#166
Merged
Conversation
The test triggered `server.close` from inside the 10th request handler (before the sleep and response). A flaky Windows CI failure showed the client retrying a request and hitting "actively refused" when the fresh TCP connect raced against the test tearing down the listening socket. Keep the in-flight close behavior — `server.close` still fires while the 10th handler is sleeping, so it still has to wait for the handler to drain — but wait for the client to confirm it received all 10 responses before closing the listening socket.
'in-tenth-handler' / 'ten-done' would go stale if CLOSE-AFTER-REQUESTS ever changes.
Member
Author
|
TBR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test triggered
server.closefrom inside the 10th request handler (before the sleep and response). A flaky Windows CI failure showed the client retrying a request and hitting "actively refused" when the fresh TCP connect raced against the test tearing down the listening socket.Keep the in-flight close behavior —
server.closestill fires while the 10th handler is sleeping, so it still has to wait for the handler to drain — but wait for the client to confirm it received all 10 responses before closing the listening socket.