Skip to content

Fix race in server-close test that flaked on Windows. #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
floitsch merged 2 commits into from
May 24, 2026
Merged

Fix race in server-close test that flaked on Windows. #166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f697102
Fix race in server-close test that flaked on Windows.
floitsch May 24, 2026
a4727b9
Rename latches to avoid baking the request count into the variable name.
floitsch May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions tests/server-close-test.toit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,15 @@ test --request-more/bool=false:
network := net.open
tcp-socket := network.tcp-listen 0
port := tcp-socket.local-address.port
served-ten := monitor.Latch
closed := monitor.Latch
close-trigger := monitor.Latch
requests-done := monitor.Latch
client-done := monitor.Latch
task::
requests := 0
server.listen tcp-socket:: | request/http.Request writer/http.ResponseWriter |
requests++
if requests == 10: served-ten.set true
sleep --ms=100 // Make it more likely to have parallel requests.
if requests == CLOSE-AFTER-REQUESTS: close-trigger.set true
sleep --ms=100 // Stretch the handler so server.close has to wait.
if request.path == "/":
writer.headers.set "Content-Type" "text/html"
writer.out.write "<html><body>hello world</body></html>"
Expand All @@ -36,17 +37,28 @@ test --request-more/bool=false:
// 10 requests should be no problem.
CLOSE-AFTER-REQUESTS.repeat:
client.get --uri="http://localhost:$port/"
requests-done.set true

if request-more:
// There might still be some requests that made it through, but
// now we should soon have issues.
e := catch:
with-timeout --ms=1000:
with-timeout --ms=2000:
while true:
client.get --uri="http://localhost:$port/"
sleep --ms=10
expect-not-null e
client-done.set true

served-ten.get
// Trigger close while the last handler is still in flight, so we verify
// that server.close waits for in-flight handlers to complete.
close-trigger.get
server.close
// server.close has returned, so all handlers are done. But the client
// may still be reading the last response. Wait for the client to
// confirm receipt before tearing down the listening socket, otherwise
// a mid-stream close on Windows can show up as RST and trigger a retry
// that hits the closed listener with "actively refused".
requests-done.get
tcp-socket.close
client-done.get
Loading