test(ts-sdk): explicit timeouts on environment-scaled live e2e reads - #957
Merged
Conversation
export() and the flat account.metrics() aggregate scale with account population and environment load; in the release pipeline they run right after the conformance battery against a still-draining staging DB, where vitest's 5s default failed twice (2026-08-28) while the endpoints answer in ~1s idle. Same precedent and do-not-tidy rule as the grouped-metrics test's existing explicit timeout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScEpytuD7GvaXEssvJ2W32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final piece of today's release-gate stabilization (with #954 test hygiene and #955 the wsd index).
The pipeline's client-surface gates run the TS SDK live suite immediately downstream of the conformance battery, against a staging DB still draining that suite's async churn. Two reads whose cost scales with account population —
export()and the flataccount.metrics()— sat right at vitest's 5s default there (both failed at exactly the default in two consecutive pipeline attempts, while answering in ~1s on idle staging). The grouped-metrics test in the same file already carries an explicit 30s timeout with a "do not tidy this back" comment for precisely this reason; this PR applies the same treatment (and comment) to the other two environment-scaled reads.No behavior change; live tests still skip without env. Needed in the next tag (v1.8.2) for the pipeline to pass its client gates reliably.
🤖 Generated with Claude Code
https://claude.ai/code/session_01ScEpytuD7GvaXEssvJ2W32